Conversation
davidmrc6
force-pushed
the
fix/groups-bug
branch
from
ce0df02 to
b2b8787
Compare
* Fix lint * Releases time-out and offline check * Releases UI changes * UI default group setting fixed
* Updated releases information URLs * Some fixes related to licensing
davidmrc6
commented
Mar 27, 2026
| foreach (self::WORKSPACES as $slug => $uuid) { | ||
| try { | ||
| $response = $this->httpClient->get(self::BASE_URL . $uuid); | ||
| $response = $this->httpClient->get(self::BASE_URL . $uuid, ['timeout' => 5]); |
Collaborator
Author
There was a problem hiding this comment.
why the timeout?
Collaborator
There was a problem hiding this comment.
In case release proxy is not reachable, it's more graceful
Collaborator
Author
|
Looks good |
usselite
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some bugs + adds the new releases api
Also added url hash based routing to make navigation a bit easier since we have different tabs. I left all of that in one commit, up to you @usselite if you'd like to keep that or not, thought i'd include it regardless