1.3.2: Defer throttle edge case optimization#148
Merged
Conversation
sambostock
changed the title
sambostock
force-pushed
the
defer-throttle-edge-case-optimization
branch
from
1d22245 to
2e15d54
Compare
This customizable job is more reusable, for other scenarios such as passing in non-Enumerator objects.
This optimization turns out to break backwards compatibility in two known ways: - Couples ThrottleEnumerator to the Enumerator API, whereas previously any object responding to .each could be wrapped. - Checking for throttling before each iteration breaks certain throttle_on implementations which rely on being called after each iteration. Therefore, the change will be deferred until the next major version bump.
sambostock
force-pushed
the
defer-throttle-edge-case-optimization
branch
from
2e15d54 to
03564a2
Compare
This was referenced Nov 13, 2021
vahe
approved these changes
Nov 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #87 and bumps the gem version to 1.3.2.
#87 turns out to break a some things, so we're reverting the change and re-publishing them in 2.0.0.
ThrottleEnumeratorto theEnumeratorAPI, whereas previously any object responding to .each could be wrapped.throttle_onimplementations which rely on being called after each iteration.See this Slack discussion for details.
I have left the original test, but skipped it, following the pattern I used in #77.