Ensure type-safe deserialization#417
Merged
Merged
Conversation
sambostock
approved these changes
Aug 16, 2023
sambostock
left a comment
sambostock
left a comment
Contributor
There was a problem hiding this comment.
Changelog needs updating, but otherwise seem fine.
Mangara
force-pushed
the
mangara-serialize-total-time
branch
from
aa62c54 to
1734a3e
Compare
|
Thanks a lot @Mangara . I came back from (long) holidays a couple of days ago and I was planning to resume this. Appreciate that you took care. Awesome! BTW is the any official release planned or should I keep pinning main branch revisions? |
Contributor
Author
We're planning a new release this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #396
#405 appears abandoned, so this re-creates it for both
total_timeandtimes_interrupted, just in case.The new deserialization will raise something like
ArgumentError (invalid value for Float(): "bar")when the value cannot be converted properly.CC @wandering-tales