Skip to content

Add Tapioca compiler#533

Merged
st0012 merged 3 commits into
mainfrom
add-tapioca-compiler
Jan 21, 2025
Merged

Add Tapioca compiler#533
st0012 merged 3 commits into
mainfrom
add-tapioca-compiler

Conversation

@st0012

@st0012 st0012 commented Jan 15, 2025

Copy link
Copy Markdown
Member

No description provided.

@st0012 st0012 force-pushed the add-tapioca-compiler branch 2 times, most recently from c189641 to a80d9ea Compare January 15, 2025 19:39
Comment thread lib/tapioca/dsl/compilers/job_iteration.rb Outdated

@Mangara Mangara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this initially - can we generate a signature for perform as well? It'll be the same type signature as perform_now, but an instance method, instead of a class method.

Comment thread lib/tapioca/dsl/compilers/job_iteration.rb Outdated
Comment thread lib/tapioca/dsl/compilers/job_iteration.rb Outdated
@st0012 st0012 force-pushed the add-tapioca-compiler branch 3 times, most recently from 3424803 to c76569d Compare January 15, 2025 21:36
Comment thread lib/tapioca/dsl/compilers/job_iteration.rb Outdated
Comment thread lib/tapioca/dsl/compilers/job_iteration.rb Outdated
@st0012 st0012 force-pushed the add-tapioca-compiler branch 2 times, most recently from fceeb76 to 02fc468 Compare January 16, 2025 21:28

@Mangara Mangara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI failures are addressed.

@st0012 st0012 force-pushed the add-tapioca-compiler branch 3 times, most recently from a1a68ef to df26d0d Compare January 20, 2025 17:29
@st0012 st0012 requested review from Mangara and paracycle January 20, 2025 17:50
@st0012 st0012 marked this pull request as ready for review January 20, 2025 17:50
@st0012 st0012 force-pushed the add-tapioca-compiler branch from 78130d0 to bb95472 Compare January 20, 2025 18:32
It takes the job's `build_enumerator` method and generates the signatures
for the job's corresponding `perform_later` and `perform_now` methods.
@st0012 st0012 force-pushed the add-tapioca-compiler branch from 4ae6408 to 79a7ba3 Compare January 20, 2025 19:51
@st0012 st0012 added the enhancement New feature or request label Jan 20, 2025
@st0012 st0012 merged commit 5f44ee6 into main Jan 21, 2025
@st0012 st0012 deleted the add-tapioca-compiler branch January 21, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants