Skip to content

Test against Ruby 2.7 and fix a couple warnings#54

Merged
casperisfine merged 1 commit into
masterfrom
ruby-2.7
Jun 4, 2020
Merged

Test against Ruby 2.7 and fix a couple warnings#54
casperisfine merged 1 commit into
masterfrom
ruby-2.7

Conversation

@casperisfine

@casperisfine casperisfine commented Jun 4, 2020

Copy link
Copy Markdown
Contributor

Should fix:

DEPRECATION WARNING: /tmp/bundle/ruby/2.7.0/gems/job-iteration-1.1.6/lib/job-iteration/iteration.rb:73: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
eagerlib/background_queue/job.rb:258: warning: The called method `retry_job' is defined here
 (called from retry_job at /tmp/bundle/ruby/2.7.0/gems/job-iteration-1.1.6/lib/job-iteration/iteration.rb:73)

kirs
kirs approved these changes Jun 4, 2020
View reviewed changes

@kirs kirs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@casperisfine casperisfine merged commit 19647b5 into master Jun 4, 2020
@casperisfine casperisfine temporarily deployed to rubygems June 4, 2020 18:35 Inactive
@sambostock sambostock deleted the ruby-2.7 branch February 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etiennebarrie etiennebarrie etiennebarrie approved these changes

@kirs kirs kirs approved these changes

@GustavoCaso GustavoCaso Awaiting requested review from GustavoCaso

@rafaelfranca rafaelfranca Awaiting requested review from rafaelfranca

@Edouard-chin Edouard-chin Awaiting requested review from Edouard-chin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@casperisfine @etiennebarrie @kirs @byroot
⚡