Skip to content

Optimize bokeh blur convolution #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimBobSquarePants merged 22 commits into from
Dec 15, 2020
Merged

Optimize bokeh blur convolution #1475

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
efeb1c4
Add BokehBlur benchmark
Sergio0694 Dec 12, 2020
d8453bc
Minor code refactoring to improve flexibility
Sergio0694 Dec 12, 2020
faa1ad1
Switched bokeh blur to optimized pipeline
Sergio0694 Dec 12, 2020
6bb300a
Specialize bokeh blur operations for 1D kernels
Sergio0694 Dec 12, 2020
c72a3bb
Minor code tweaks
Sergio0694 Dec 12, 2020
04d66a9
Restore temporary changes
Sergio0694 Dec 12, 2020
b2f397d
Remove unnecessary code
Sergio0694 Dec 12, 2020
3180ec4
Fix gamma processing out of image bounds
Sergio0694 Dec 12, 2020
7db1225
Fix blur processing when constrained to region
Sergio0694 Dec 12, 2020
50f9716
Fix NullReferenceException in KernelSamplingMap.Dispose
Sergio0694 Dec 12, 2020
9fca028
Remove allocation constrained test for bokeh blur
Sergio0694 Dec 13, 2020
2e53a44
Remove unnecessary offset indirections
Sergio0694 Dec 13, 2020
e4ba017
Add optimized paths for default gamma exposure
Sergio0694 Dec 14, 2020
cb18c58
Switch to vectorized clamping
Sergio0694 Dec 14, 2020
5c89d0a
Initial vectorized cube root implementation
Sergio0694 Dec 14, 2020
442e467
Fix vectorized cube root on x86-64 with no SSE41
Sergio0694 Dec 14, 2020
c38fc81
Minor codegen tweaks
Sergio0694 Dec 14, 2020
0d27e04
Add discontigous buffers and intrinsics tests
JimBobSquarePants Dec 14, 2020
8ab5e6f
Fix feature test runner
JimBobSquarePants Dec 14, 2020
c52112c
Switch to explicit SSE Newton approximations
Sergio0694 Dec 14, 2020
9142e72
Add FMA support, more SSE optimizations
Sergio0694 Dec 14, 2020
a8cae3f
Add more codegen improvements
Sergio0694 Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ImageSharp/Processing/Processors/Convolution/KernelSamplingMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ public void Dispose()
{
if (!this.isDisposed)
{
this.yOffsets.Dispose();
this.xOffsets.Dispose();
this.yOffsets?.Dispose();
Comment thread
JimBobSquarePants marked this conversation as resolved.
this.xOffsets?.Dispose();

this.isDisposed = true;
}
Expand Down
⚡