Updated Colourful from 2.0.5 to 3.0.0 (only benchmarks affected)#1691
Merged
JimBobSquarePants merged 1 commit intoJul 12, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
=======================================
Coverage 84.33% 84.33%
=======================================
Files 816 816
Lines 35908 35908
Branches 4173 4173
=======================================
Hits 30282 30282
Misses 4804 4804
Partials 822 822
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Member
|
Ah fantastic @tompazourek thanks for this! Did you run the benchmarks? Any changes? |
Contributor
Author
|
@JimBobSquarePants I ran the benchmarks locally and noticed that Colourful performed a bit better than before. I think in one case (I think it was the Lab conversion), it might even have outperformed the current ImageSharp solution. |
Member
|
@tompazourek Nice work! |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The Colourful library is used in the benchmarks, and recently, there was a version 3.0.0 released. I updated the package reference, and the converter code to reflect the new API.