Fix for Jpeg Metadata Decoding with unknown APP13 profile#1931
Merged
Conversation
Member
|
Thanks for your submission @mkehoe we really appreciate it.
I'm assuming this is due to privacy concerns? Is so, no worries. The change is a reasonable optimization without the test image. |
JimBobSquarePants
approved these changes
Jan 10, 2022
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
======================================
Coverage 88% 88%
======================================
Files 966 966
Lines 51320 51321 +1
Branches 6397 6397
======================================
+ Hits 45188 45189 +1
Misses 5074 5074
Partials 1058 1058
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix for Jpeg Decoding Metadata for unknown APP13 profiles. Without this fix the parser will continue parsing any non-Photoshop profile looking for markers and under the right circumstances cause the SOS marker to get missed. Sorry not able to provide the image where this issue was originally encountered for a test case.