Add event for player toggling entity age lock#8555
Open
CrebsTheCoder wants to merge 17 commits into
Open
Conversation
CrebsTheCoder
requested review from
Efnilite and
Pesekjak
and removed request for
a team
skriptlang-automation
Bot
added
the
needs reviews
Contributor
|
Please target dev/feature or dev/patch instead of master. (feature in this case) |
Contributor
Author
Oops sorry |
Absolutionism
requested changes
Apr 17, 2026
Absolutionism
left a comment
Absolutionism
left a comment
Contributor
There was a problem hiding this comment.
Unsure if there is a delay when applying the new age lock to the entity.
Should check this to see if a EventValueExpression is needed, or if users can simply check the age lock on the event-entity to determine the behavior they wish to proceed with.
Contributor
|
btw, no big concern, but the code snippet you provided does not match the output shown in the screenshot. |
Absolutionism
requested changes
Apr 18, 2026
Absolutionism
left a comment
Absolutionism
left a comment
Contributor
There was a problem hiding this comment.
A JUnit test would be nice
…nts/events/EvtPlayerToggleEntityAge.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Efnilite
requested changes
Apr 19, 2026
skriptlang-automation
Bot
removed
the
needs reviews
…nts/events/EvtPlayerToggleEntityAge.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…nts/events/EvtPlayerToggleEntityAge.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…t changes syntax because "test "EvtPlayerToggleEntityAge" if running minecraft "26.1" doesn't exist
Efnilite
requested changes
Apr 20, 2026
sovdeeth
added
the
enhancement
sovdeeth
requested changes
Apr 21, 2026
sovdeeth
requested changes
Apr 23, 2026
…l handling in toString
APickledWalrus
requested changes
May 5, 2026
APickledWalrus
requested changes
May 27, 2026
APickledWalrus
left a comment
APickledWalrus
left a comment
Member
There was a problem hiding this comment.
Nearly ready, good work so far
Comment on lines
+46
to
+47
| EventValues.registerEventValue(PlayerToggleEntityAgeLockEvent.class, LivingEntity.class, PlayerToggleEntityAgeLockEvent::getEntity); | ||
| EventValues.registerEventValue(PlayerToggleEntityAgeLockEvent.class, ItemStack.class, PlayerToggleEntityAgeLockEvent::getItem); |
Member
There was a problem hiding this comment.
Can use updated event value registration. See BukkitEventValues for many examples
| .addEvent(PlayerToggleEntityAgeLockEvent.class) | ||
| .addPatterns("[player] entity age ([:un]lock|toggle:toggle) [of %-entitytypes%]") | ||
| .addDescription("Called when a player toggles the age lock of an entity using a golden dandelion.") | ||
| .addExample(""" |
Member
There was a problem hiding this comment.
I would split this into 3 separate examples (one per event)
Absolutionism
requested changes
May 30, 2026
…nts/events/EvtPlayerToggleEntityAge.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Would be usefull to check if a player locks an entity age
Solution
Registered an event to be called wen a player locks an entity age
Testing Completed
Supporting Information
Completes: none
Related: none
AI assistance: none