Add callback support to EnumClassInfo and RegistryClassInfo#8677
Open
APickledWalrus wants to merge 1 commit into
Open
Add callback support to EnumClassInfo and RegistryClassInfo#8677APickledWalrus wants to merge 1 commit into
APickledWalrus wants to merge 1 commit into
Conversation
APickledWalrus
requested review from
Pesekjak and
UnderscoreTud
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
added
the
enhancement
skriptlang-automation
Bot
removed
the
needs triage
Absolutionism
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is a need to take certain actions during the parsing of elements for EnumClassInfo and RegistryClassInfo. For example, printing a deprecation warning when certain elements are used.
Solution
This pull request implements the ability to provide a
parseCallback, a Consumer of the parsed element, when creating an EnumClassInfo or RegistryClassInfo.This was inspired by some changes I was making to teleport flags (as some are now deprecated). Here is an example making use of a callback:
While here, I have also deprecated the methods with a
registerComparatoroption. This functionality is no longer needed as Comparators properly handle the cases that necessitated the option.Testing Completed
Manual testing (see above photo)
Supporting Information
n/a
Completes: none
Related: none
AI assistance: none