Fix MiniMessage Tag Serialization Order#8681
Open
APickledWalrus wants to merge 2 commits into
Open
Conversation
APickledWalrus
requested review from
Pesekjak and
TheMug06
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
1 task
skriptlang-automation
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the decorations tag is serialized before the color tag, which causes the decorations to be lost when deserializing if the
color codes reset formattingis enabled (which is the case by default).See #8680 for further information.
Solution
Forces the
colortag to come after thedecorationstag in our custom resolver.Also cleans up the actual construction of the custom resolvers.
Testing Completed
I included a small test in
TextModule.skSupporting Information
n/a
Completes:
Related: none
AI assistance: none