Prevent Concurrent Script Loads/Unloads#8687
Open
APickledWalrus wants to merge 2 commits into
Open
Conversation
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
added
bug
This was
linked to
issues
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It is possible to load/unload a script while it is already being loaded/unloaded. This causes things to blow up.
Solution
Implements file tracking in ScriptLoader to prevent concurrent loads/unloads. I'm feeling slightly mixed on this approach, but it seems to perform well enough (for now). I've also included some changes to the script loading syntaxes to improve their safety.
Includes a minor cleanup of ScriptLoader as well.
Testing Completed
Tested manually with the code of the linked issues.
Supporting Information
I did consider a load/unload queue as an alternative, but the implementation is far more complex (especially to handle with syntax), and I did not feel it was worth it as this time.
Completes:
reloadsyntax #8508Related: none
AI assistance: none