Fix EffFeed

[hotpoc]

Problem

The person who updated the now current feed effect forgot to add a max level, so it stacks every time you do the normal feed player. I think it should instead only go above the max if specified with by %-number%, as it makes more sense logically (at least in my head).

Solution

It fixes it by just setting the food level to 20 if the beef amount isn't set.

Testing Completed

I did:
!feed player
!send food level of me

!feed player by 40
!send food level of me

And it seemed to work fine

Supporting Information

I guess it's a breaking change if players are using it specifically to stack feed themselves? I don't see why anyone would, though.

---

Completes: none
Related: none
AI assistance: none

[AnOwlBe]

wonder if this would be better as an expr eg set saturation of player to 5 add 5 to saturation of player

edit: nvm ignore me that already exists

[TheMug06]

Please target dev/patch or dev/feature

[TheMug06]

lgtm apart from requested change and base branch

[TheMug06]

I don't see how [the] is needed in this pattern, seeing as the player is already valid. Which would make feed the the player and feed the {_list::*} possible.

[AnOwlBe]

am I missing something or did you remove the registry just to replace it with the older deprecated registry-

[TheMug06]

Oop i forgot about the new registry
Yeah please stick to the new registry!!!

[TheMug06]

Please use the new registry system instead of reverting to the old one!

[hotpoc]

am I missing something or did you remove the registry just to replace it with the older deprecated registry-

i was gonna use the newer one but all the files i checked that used it all had their own module things to register them with. i didn't really know where to put it. where should it go?

[AnOwlBe]

in playermodule as its relating to feeding a player