Conversation
|
|
||
| const app = express() | ||
| const port = process.env.PORT || 3001 | ||
| const port = process.env.PORT || 3000 |
| app.use(express.json()); | ||
| app.use(morgan('dev')); | ||
| app.use(express.static('public/build')) | ||
| //app.use(express.static('public/build')) |
Member
There was a problem hiding this comment.
Why have you commented out the static directory ?
|
|
||
| app.use(function(req, res){ | ||
| res.sendFile('public/build/index.html', {root: __dirname}); | ||
| res.sendFile('public/public/index.html', {root: __dirname}); |
Member
There was a problem hiding this comment.
This is linked with serving the files after building. It should not be modified unless the build folder is modified. Why did you change it though?
| "name": "bonafide-system", | ||
| "version": "0.1.0", | ||
| "private": true, | ||
| "homepage": "/", |
| no_copies: ele.getDataValue('no_copies') | ||
|
|
||
| }) | ||
| sendResponse(ele); |
Member
There was a problem hiding this comment.
Having the same body 3 times is taken care of in another PR.
Member
gigatesseract
left a comment
gigatesseract
left a comment
There was a problem hiding this comment.
Rebase your work once, to do away with formatting changes.
Also, can you specify one line comments at places where ive asked why?
Author
|
yep i will do the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.