Installer: use local French.isl added in #11506#11509
Merged
Merged
Conversation
PR #11506 added installer/WindowsInno/Languages/French.isl, but the [Languages] entry for "fr" still pointed at the Inno Setup compiler's own French.isl (compiler: prefix), so the contributed file was unused. Drop the compiler: prefix so the "fr" language uses the repo's local French.isl, matching the other locally-shipped translations (Catalan, Greek, Farsi, Italian, Croatian, Serbian, Chinese, ...). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11506.
That PR added
installer/WindowsInno/Languages/French.isl, but the[Languages]entry forfrstill referenced the Inno Setup compiler's bundled French file (compiler:Languages\French.isl), so the contributed translation was never actually used.This drops the
compiler:prefix sofrloads the repo's localLanguages\French.isl, consistent with the other locally-shipped translations (Catalan, Greek, Farsi, Italian, Croatian, Serbian Cyrillic/Latin, Chinese Simplified/Traditional).Verified the merged
French.islis the official Inno Setup 6.5.0+ French translation (LanguageID=$040C, codepage 1252,[LangOptions]/[Messages]/[CustomMessages]all present). Its[CustomMessages]block holds only standard Inno messages, so it does not conflict with the SE-specificfr.*messages inSubtitle_Edit_Localization.iss.🤖 Generated with Claude Code