Rebuild toolbar icons when system dark/light mode changes#11558
Merged
niksedk merged 1 commit intoJun 12, 2026
Merged
Conversation
When Theme is set to System, switching macOS between dark and light mode fired ActualThemeVariantChanged but only re-applied button/menu styles — the toolbar PNG icons (loaded from Dark/ or Light/ theme folder at startup) were never reloaded, leaving them faded/inverted. Add a SystemThemeChangedCallback on UiTheme and invoke it after SetCurrentTheme(); MainViewModel wires it to a new RebuildToolbar() helper (extracted from the existing ApplySettings and LoadLanguage inline copies).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Theme is set to System, switching macOS between dark and light mode fired ActualThemeVariantChanged but only re-applied button/menu styles — the toolbar PNG icons (loaded from Dark/ or Light/ theme folder at startup) were never reloaded, leaving them faded/inverted (see screenshot below).
Add a SystemThemeChangedCallback on UiTheme and invoke it after SetCurrentTheme(); MainViewModel wires it to a new RebuildToolbar() helper (extracted from the existing ApplySettings and LoadLanguage inline copies).