Skip to content

Add bordered UI sections to main editor and Fix Common Errors dialog#11568

Closed
mjuhasz wants to merge 3 commits into
SubtitleEdit:mainfrom
mjuhasz:tweak/bordered-ui-sections
Closed

Add bordered UI sections to main editor and Fix Common Errors dialog#11568
mjuhasz wants to merge 3 commits into
SubtitleEdit:mainfrom
mjuhasz:tweak/bordered-ui-sections

Conversation

@mjuhasz

@mjuhasz mjuhasz commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses feedback that the subtitle list and edit area visually blend together.

Main window

  • Wraps the subtitle DataGrid and the edit box (with timing, formatting, and info controls) in separate gray-bordered panels, replacing the plain horizontal separator between them.
main window

Fix Common Errors — Step 2

  • Each grid (fixes and subtitles) now has its own gray border.
  • The "Select all / Invert / Refresh / Apply" buttons sit in the visible gap between the two grids.
  • The edit panel is left-aligned with the subtitles grid at a fixed width, with navigation buttons (Back to fix list, Done, Cancel) anchored to its bottom-right.
  • The fixes-applied count moves next to the step title, separated by a vertical divider that hides when no fixes have been applied.
  • MinWidth raised to prevent button clipping on narrow windows.
Fix common errors

Miklos Juhasz added 2 commits June 12, 2026 16:12
Wrap the subtitle list and edit box in the main window with matching
gray bordered panels, replacing the plain separator. In Fix Common
Errors, restructure step 2 so the fixes and subtitles grids each have
their own border, the action buttons sit in the gap between them, and
the edit panel is left-aligned below the subtitles grid at a fixed width.
Move navigation buttons (Back, Done, Cancel) alongside the edit panel
in the bottom row so they align with the subtitle text controls rather
than floating at the window bottom. Move the fixes-applied label next
to the step title with a separator that hides when no fixes have been
applied. Raise MinWidth to prevent buttons being clipped on narrow windows.
The subtitle TextBox had no fixed height and VerticalAlignment.Stretch,
causing it to grow to fit content when long-text rules were selected,
which shrank the grids above it.
@mjuhasz

mjuhasz commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@niksedk I see that you have not merged this one. I'm always open to feedback if there is something you don't like or would do differently, or if you would like me to explain my thinking.

@niksedk

niksedk commented Jun 13, 2026

Copy link
Copy Markdown
Member

@niksedk I see that you have not merged this one. I'm always open to feedback if there is something you don't like or would do differently, or if you would like me to explain my thinking.

I've tried to remove most of the boxes from SE4 on purpose, so I will close this for now.

@niksedk niksedk closed this Jun 13, 2026
@OmrSi

OmrSi commented Jun 14, 2026

Copy link
Copy Markdown
Member

@niksedk Especially in the main window, the textbox area doesn't look good without a border/separator at all. It looks very blended with the listview.
It needs at least a separator here, or something to give it its own space and defined borders. Even a disabled GridSplitter might work.

Here is the case I'm talking about:
image

@mjuhasz

mjuhasz commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

There is also some inconsistency here that would be good to resolve, in whatever interface guidelines the app wants to follow.

For example, the OCR window grid is boxed (see screenshot below), but the main window grid is not, and it looks out of place to my eyes, similar to the Fix common errors grids: when the lowermost rows are cut (see FCE screenshot below) it looks like we dropped some buttons / a textbox on top of the grid and they are floating, and I get the same depth perception on the main window grid.

OCR window:

OCR

Fix Common Errors window:

FCE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants