Add bordered UI sections to main editor and Fix Common Errors dialog#11568
Closed
mjuhasz wants to merge 3 commits into
Closed
Add bordered UI sections to main editor and Fix Common Errors dialog#11568mjuhasz wants to merge 3 commits into
mjuhasz wants to merge 3 commits into
Conversation
added 2 commits
June 12, 2026 16:12
Wrap the subtitle list and edit box in the main window with matching gray bordered panels, replacing the plain separator. In Fix Common Errors, restructure step 2 so the fixes and subtitles grids each have their own border, the action buttons sit in the gap between them, and the edit panel is left-aligned below the subtitles grid at a fixed width.
Move navigation buttons (Back, Done, Cancel) alongside the edit panel in the bottom row so they align with the subtitle text controls rather than floating at the window bottom. Move the fixes-applied label next to the step title with a separator that hides when no fixes have been applied. Raise MinWidth to prevent buttons being clipped on narrow windows.
The subtitle TextBox had no fixed height and VerticalAlignment.Stretch, causing it to grow to fit content when long-text rules were selected, which shrank the grids above it.
Contributor
Author
|
@niksedk I see that you have not merged this one. I'm always open to feedback if there is something you don't like or would do differently, or if you would like me to explain my thinking. |
Member
I've tried to remove most of the boxes from SE4 on purpose, so I will close this for now. |
Member
|
@niksedk Especially in the main window, the textbox area doesn't look good without a border/separator at all. It looks very blended with the listview. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Addresses feedback that the subtitle list and edit area visually blend together.
Main window
Fix Common Errors — Step 2
MinWidthraised to prevent button clipping on narrow windows.