Oculus Camera App Prototype by natezzz · Pull Request #11 · Sushisushi-sandesu/sushi

natezzz · 2015-11-30T12:28:17Z

Added basic functionality for camera app. (Take screenshots by pressing F key)

tomoasleep · 2015-11-30T12:36:35Z

Are there left tasks which you should do before we start to implement touch interaction features?
If there are not, we review your code in order to merge 👍

natezzz · 2015-11-30T12:47:45Z

@tomoasleep Nope, except that I haven't tested the code because I don't have a Leap Motion at hand. If with Leap it can display screenshot correctly, then it's okay to merge.

tomoasleep · 2015-11-30T12:51:14Z

OK, we check and review your implementation 👍

@Sushisushi-sandesu/leap-team というわけでよろ 🙏

tomoasleep · 2015-11-30T13:24:17Z

I want you to make this method private if it is not a callback method or is not called from other classes.

Cannot. they are overriden methods which are to be called by Unity engine.

Callback methods such as Start and Update are defined in superclasses, but this method TakeScreenshot seems not to be defined in superclasses.

http://docs.unity3d.com/ScriptReference/MonoBehaviour.html

ganmacs · 2015-12-02T02:22:42Z

👀 👍

tomoasleep · 2015-12-02T03:40:44Z

I think the default code format of MonoDevelop is Mono,
but it is ok to space between method names and parentheses.

natezzz · 2015-12-02T03:45:40Z

@tomoasleep Yes. The default is Mono style.
However I used "visual studio" style for this code.

natezzz · 2015-12-02T03:46:43Z

Ah. Clicked "close" by accident.

tomoasleep · 2015-12-02T03:50:43Z

I see

tomoasleep · 2015-12-02T03:51:53Z

I think your code style is different from Visual Studio code style in if statement and method call.
https://msdn.microsoft.com/en-us/library/ff926074.aspx

natezzz · 2015-12-02T03:56:15Z

@tomoasleep Yes. The Mono formatter didn't format the code completely according to the Microsoft convention. I don't know why.
Maybe we should use mono style instead?

tomoasleep · 2015-12-02T03:56:18Z

Looks good to me (OK to merge if another one says OK)

tomoasleep · 2015-12-02T04:02:48Z

Forget to check if it moves... I check it now.

takuti · 2015-12-03T12:16:06Z

It works (also w/ LeapMotion cam)!!

All errors are caused because,

all of them are not loaded in an initial cloned repository.

natezzz · 2015-12-03T12:16:45Z

ああああああああああ、泣きそう @takuti

natezzz · 2015-12-03T12:17:40Z

@takuti But what caused it not to be loaded though?

But it's awesome that it worked!!

takuti · 2015-12-03T12:17:41Z

🎉 🎉 🎉 🎉 🌞

takuti · 2015-12-03T12:19:32Z

@natezzz I don't know...are any important files describing connection between the canvas and related files in .gitignore...?

takuti · 2015-12-03T12:23:55Z

After solving the initial loading problem, we can merge this pull request 😨

natezzz · 2015-12-03T12:24:47Z

@takuti Yes!

However I think the .meta files in this commit are indeed broken.

takuti · 2015-12-03T12:28:12Z

@natezzz Now my sushi project repo works correctly, and current output of git status is

On branch camera-app
Your branch is up-to-date with 'origin/camera-app'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   Assets/_Scenes/CameraScene.unity
        deleted:    Assets/_Scenes/MainScene.unity.meta
        modified:   ProjectSettings/AudioManager.asset
        modified:   ProjectSettings/DynamicsManager.asset
        modified:   ProjectSettings/EditorBuildSettings.asset
        modified:   ProjectSettings/EditorSettings.asset
        modified:   ProjectSettings/GraphicsSettings.asset
        modified:   ProjectSettings/InputManager.asset
        modified:   ProjectSettings/NavMeshAreas.asset
        modified:   ProjectSettings/NetworkManager.asset
        modified:   ProjectSettings/Physics2DSettings.asset
        modified:   ProjectSettings/ProjectSettings.asset
        modified:   ProjectSettings/QualitySettings.asset
        modified:   ProjectSettings/TagManager.asset
        modified:   ProjectSettings/TimeManager.asset

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        Assets/Scripts/ScreenShotScript.cs.meta
        Assets/_Scenes/CameraScene.unity.meta

Hence, the reasons will be in them.

natezzz · 2015-12-03T12:29:30Z

Yes I think so. Can you push your updated camera-app to this branch instead?

natezzz · 2015-12-03T12:30:36Z

@takuti please wait.

natezzz · 2015-12-03T12:30:45Z

@takuti I'll push another commit

takuti · 2015-12-03T12:31:06Z

@natezzz yes plz

tomoasleep · 2015-12-03T12:44:46Z

3 'Fix .meta problem' ...

natezzz · 2015-12-03T12:45:12Z

@tomoasleep Sorry. Kinda messed up a little during commit ...

natezzz · 2015-12-03T12:45:38Z

@tomoasleep @takuti I just "git clone" and checked. It should be working fine now. Please review.

takuti · 2015-12-03T12:59:02Z

I have checked on my local, and it works well by just importing Leap Motion core assets. It was able to capture a screenshot as I posted before! 👍

natezzz · 2015-12-03T13:00:31Z

@takuti Nice. Now we need another reviewer and we are ready to merge. 👍
@Sushisushi-sandesu/all Someone please review if convenient 🙏

tomoasleep · 2015-12-03T13:04:21Z

@natezzz good job 🎉

natezzz · 2015-12-03T13:06:16Z

Thank you! @tomoasleep @takuti

Oculus Camera App Prototype

Added camera app prototype

462fae1

tomoasleep added the in progress label Nov 30, 2015

takuti added this to the Camera App Improvement milestone Nov 30, 2015

takuti assigned natezzz Nov 30, 2015

takuti added the Oculus label Nov 30, 2015

tomoasleep changed the title ~~[WIP] Oculus Camera App Prototype~~ Oculus Camera App Prototype Nov 30, 2015

tomoasleep added Ready for review and removed in progress labels Nov 30, 2015

tomoasleep reviewed Nov 30, 2015
View reviewed changes

natezzz added 3 commits November 30, 2015 22:58

Updated Screenshot scipt. Untrack .asset file

de94403

Added newline to the end. Tracks ProjectSettings.asset

b7dd7ae

Added modified scene

9f23d47

natezzz closed this Dec 2, 2015

tomoasleep removed the Ready for review label Dec 2, 2015

natezzz reopened this Dec 2, 2015

tomoasleep added the in progress label Dec 2, 2015

natezzz added 3 commits December 3, 2015 21:31

Fix .meta problem

28d0ca6

Fix .meta problem

7a15515

Fix .meta problem

16e6cd9

natezzz added Ready for review and removed bug labels Dec 3, 2015

natezzz added a commit that referenced this pull request Dec 3, 2015

Merge pull request #11 from Sushisushi-sandesu/camera-app

0cf6601

Oculus Camera App Prototype

natezzz merged commit 0cf6601 into master Dec 3, 2015

tomoasleep removed the Ready for review label Dec 3, 2015

natezzz removed the Oculus label Dec 3, 2015

natezzz deleted the camera-app branch December 3, 2015 13:27

takuti mentioned this pull request Dec 7, 2015

Implement Photo Chatting App #25

Open

Conversation

natezzz commented Nov 30, 2015

Uh oh!

tomoasleep commented Nov 30, 2015

Uh oh!

natezzz commented Nov 30, 2015

Uh oh!

tomoasleep commented Nov 30, 2015

Uh oh!

tomoasleep Nov 30, 2015

Choose a reason for hiding this comment

Uh oh!

natezzz Nov 30, 2015

Choose a reason for hiding this comment

Uh oh!

tomoasleep Nov 30, 2015

Choose a reason for hiding this comment

Uh oh!

ganmacs commented Dec 2, 2015

Uh oh!

tomoasleep commented Dec 2, 2015

Uh oh!

natezzz commented Dec 2, 2015

Uh oh!

natezzz commented Dec 2, 2015

Uh oh!

tomoasleep commented Dec 2, 2015

Uh oh!

tomoasleep commented Dec 2, 2015

Uh oh!

natezzz commented Dec 2, 2015

Uh oh!

tomoasleep commented Dec 2, 2015

Uh oh!

tomoasleep commented Dec 2, 2015

Uh oh!

takuti commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

takuti commented Dec 3, 2015

Uh oh!

takuti commented Dec 3, 2015

Uh oh!

takuti commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

takuti commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015 via email

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

takuti commented Dec 3, 2015

Uh oh!

tomoasleep commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

takuti commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

tomoasleep commented Dec 3, 2015

Uh oh!

natezzz commented Dec 3, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development