Skip to content

Add new SecurityProvider to allow managing access to resource(s)#1013

Merged
NoResponseMate merged 7 commits into
Sylius:1.13from
Prometee:security-provider
May 27, 2025
Merged

Add new SecurityProvider to allow managing access to resource(s)#1013
NoResponseMate merged 7 commits into
Sylius:1.13from
Prometee:security-provider

Conversation

@Prometee

@Prometee Prometee commented May 5, 2025

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

Add a Security provider to handle security access to a resource operation.

  • Add SecurityProvider
  • Add tests
  • Add documentation

@Prometee Prometee changed the title Add new SecurityProvider to allow managing access to a resources Add new SecurityProvider to allow managing access to resource(s) May 5, 2025
@Prometee Prometee marked this pull request as ready for review May 5, 2025 17:58
@Prometee Prometee requested a review from loic425 May 5, 2025 17:58
Comment thread src/Bundle/Resources/config/services/state/provider.xml Outdated
Comment thread src/Bundle/Resources/config/services/state/provider.xml Outdated
Comment thread src/Component/src/Metadata/Operation.php Outdated
Comment thread src/Component/src/State/Provider/SecurityAttributeProviderInterface.php Outdated
Comment thread src/Component/src/State/Provider/SecurityProvider.php Outdated
@loic425

loic425 commented May 6, 2025

Copy link
Copy Markdown
Member

@Prometee Your PR is really cool, but we should think about the whole security system first.
I like the expression language on APIP too... and sth close to #[IsGranted] new Symfony attributes.

@Prometee

Prometee commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

I agree, I'm going to use the APIP way, there is a few changes to do from what I read.

@Prometee Prometee requested a review from loic425 May 6, 2025 09:52
Comment thread src/Component/src/State/Provider/SecurityProvider.php Outdated
Comment thread src/Component/src/Symfony/Security/OperationAccessChecker.php Outdated
Comment thread src/Component/src/Symfony/Security/OperationAccessChecker.php Outdated
Comment thread src/Component/src/Symfony/Security/OperationAccessChecker.php Outdated
Comment thread src/Component/src/Symfony/Security/OperationAccessChecker.php
Comment thread src/Component/src/Symfony/Security/OperationAccessChecker.php Outdated
Comment thread src/Component/src/Symfony/Security/OperationAccessChecker.php Outdated
Comment thread src/Component/src/Symfony/Security/OperationAccessChecker.php Outdated
@Prometee Prometee force-pushed the security-provider branch from 8f2ba06 to c596022 Compare May 7, 2025 15:05
@NoResponseMate NoResponseMate merged commit c698bab into Sylius:1.13 May 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants