Add tests with skeleton#1014
Merged
Merged
Conversation
loic425
commented
May 7, 2025
loic425
commented
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes (but internally) |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
NoResponseMate
approved these changes
May 26, 2025
diimpp
reviewed
May 26, 2025
Comment on lines
+213
to
+214
| set -x | ||
| php -v |
Member
There was a problem hiding this comment.
Are both of those lines still needed? I assume it was added for debug.
Suggested change
| set -x | |
| php -v |
diimpp
reviewed
May 26, 2025
|
|
||
| steps: | ||
| - | ||
| uses: actions/checkout@v2 |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@v2 | |
| uses: actions/checkout@v4 |
GSadee
added a commit
that referenced
this pull request
May 27, 2025
| Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | - | License | MIT Applied comments from #1014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.