Fix ClassReflection resource class resolving edge case#1016
Merged
Conversation
loic425
approved these changes
May 26, 2025
Member
|
@Pierstoval I've changed the base branch, could you rebase this PR from 1.12 please? |
Pierstoval
force-pushed
the
fix-resource-reflection
branch
from
c532a23 to
9a71e27
Compare
Pierstoval
force-pushed
the
fix-resource-reflection
branch
from
9a71e27 to
01d0ebf
Compare
Contributor
Author
|
Rebased it on 1.12 👌 |
NoResponseMate
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a hotfix but the overall resolution system must be re-thought.