Fix missing route name on operations attributes#994
Merged
NoResponseMate merged 1 commit intoMay 27, 2025
Conversation
loic425
commented
Feb 28, 2025
loic425
commented
Member
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
diimpp
approved these changes
Mar 3, 2025
GSadee
reviewed
Mar 12, 2025
| { | ||
| public function __construct( | ||
| ?string $path = null, | ||
| ?string $routeName = null, |
Member
There was a problem hiding this comment.
I'm considering releasing this in a patch because it could potentially be a BC break and could affect the end application 🤔
Member
Author
There was a problem hiding this comment.
Do you want me to move it at the end of the constructor? Normally, lot of people is using name parameter but you're right. I don't remember if theses classes are marked as ecperimental.
Contributor
There was a problem hiding this comment.
They're all experimental, and given the number of arguments, it's highly doubtful that anyone would just use them in order 🤷
Member
There was a problem hiding this comment.
As this is experimental, I think we can be ok with this 👌🏻
NoResponseMate
approved these changes
May 27, 2025
GSadee
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.