Add filters to enable more customization

[zackkatz]

• Added tgmpa_submenu_parent_slug filter - modify what menu the sub-page is under, instead of requiring it under "Appearance". This allows the page to be added to a plugin's sub-menu.
• Added tgmpa_table_columns filter - modify table columns in table view
• Added tgmpa_table_data_item filter - modify plugin data that's ready for the table output
• Added tgmpa_notice_rendered_action_links filter - modify final action link output

I wanted to add a "Description" column that says why should an user install this plugin.

array(
    'name'      => 'WordPress SEO by Yoast',
    'slug'      => 'wordpress-seo',
    'description' => 'This is a valuable SEO plugin.',
);

These filters allow much more flexibility in the setup.

[zackkatz]

Here's an example of how I'm doing adding a column.

add_filter( 'tgmpa_table_data_item', 'idx_plus_tgmpa_table_data_item', 10, 2 );

/**
 * Add the content for the decription row.
 * @param  array $row    $table_data[$i] from `_gather_plugin_data` method
 * @param  array $plugin $plugin  from `_gather_plugin_data` method
 * @return array         Possibly modified $row
 */
function idx_plus_tgmpa_table_data_item($row, $plugin) {
    $row['description'] = isset($plugin['description']) ? $plugin['description'] : '';
    return $row;
}

add_filter('tgmpa_table_columns', 'idx_plus_tgmpa_table_columns');

/**
 * Add a column to the Suggested Plugins table
 * @param  array $columns Array of columns key => value
 * @return array          Modified array
 */
function idx_plus_tgmpa_table_columns($columns) {

    // I also don't want these other columns.
    unset($columns['type'], $columns['source']);

    $columns['description'] = 'Description';

    return $columns;
}

And here's what it looks like:

[thomasgriffin]

I like the changes, but the biggest issue is changing add_theme_page to add_submenu_page, which will not pass Theme Check or many other plugin/theme checks. If you have any ideas beyond this, like possibly filtering the function call itself and making that dynamic instead, that would be great.

Maybe it could be separated. Have the function name itself filtered, and then have the args themselves filtered as well. I'm pretty sure dynamic function names are cool in PHP 5.2 and greater, so I don't see why you couldn't do this as well.

[zackkatz]

I was going to do call_user_func, but the add_theme_page and add_submenu_page accept a different # of arguments and also the callback was all screwy.

What about a simple boolean check with tgmpa_admin_menu_use_add_theme_page?

$args = apply_filters('tgmpa_admin_menu_args', array(
    'parent_slug'=> 'themes.php',
    'page_title' => $this->strings['page_title'],          // Page title.
    'menu_title' => $this->strings['menu_title'],          // Menu title.
    'capability' => 'edit_theme_options',                  // Capability.
    'menu_slug'  => $this->menu,                           // Menu slug.
    'function'   => array( $this, 'install_plugins_page' ) // Callback.
));

// Convert $args['page_title'] to $page_title
extract($args);

if(apply_filters( 'tgmpa_admin_menu_use_add_theme_page', true )) {
    add_theme_page($page_title, $menu_title, $capability, $menu_slug, $function);
} else {
    add_submenu_page( $parent_slug, $page_title, $menu_title, $capability, $menu_slug, $function);
}

[zackkatz]

I got rid of the extract() - less clean looking, but more secure.

[zackkatz]

@thomasgriffin have you had a chance to look at this?

[thomasgriffin]

I'm down with this if you could just fix the spacing to match the rest of the class (for WPCS).

[zackkatz]

I've updated the formatting to match.

[thomasgriffin]

Looks good - thanks!

[jrfnl]

@zackkatz Just thought I'd let you know that I intend to deprecate the tgmpa_admin_menu_use_add_theme_page filter in v2.5.0 as you can now set the parent_slug from the $config array, making the filter superfluous.

Let me know if you have any questions about this.