Skip to content

* Remove call to deprecated function screen_icon()#244

Merged
thomasgriffin merged 1 commit intoTGMPA:masterfrom
NateWr:deprecated_screen_icon_function
Jan 11, 2015
Merged

* Remove call to deprecated function screen_icon()#244
thomasgriffin merged 1 commit intoTGMPA:masterfrom
NateWr:deprecated_screen_icon_function

Conversation

@NateWr
Copy link
Copy Markdown
Contributor

@NateWr NateWr commented Jan 6, 2015

The call to these functions trigger a REQUIRED error in Theme Check, which prevents themes using this library to be submitted to the .org repository. They are unnecessary and were wrapped in a check for WordPress < 3.8 anyway.

This resolves #234.

@NateWr
Copy link
Copy Markdown
Contributor Author

NateWr commented Jan 6, 2015

It also resolves issue #224.

@bfintal
Copy link
Copy Markdown

bfintal commented Jan 11, 2015

+1

@thomasgriffin We really need this merged with master

thomasgriffin added a commit that referenced this pull request Jan 11, 2015
* Remove call to deprecated function screen_icon()
@thomasgriffin thomasgriffin merged commit e61b32f into TGMPA:master Jan 11, 2015
@jrfnl
Copy link
Copy Markdown
Contributor

jrfnl commented Jan 12, 2015

Can this please also be merged to develop ?

GaryJones pushed a commit that referenced this pull request Apr 22, 2015
Manually re-applied to develop branch due to merge conflict after applying to master branch.

props @NateWr, see #244, fixes #234
@GaryJones
Copy link
Copy Markdown
Member

Now merged into develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants