Conversation
Contributor
|
What's the real issue here ? Doesn't WP set this itself when installing themes ? Also: Merge conflict |
Contributor
|
@GaryJones How can I set file permission using git bash? If possible help me please 💖 |
Member
Author
Not that I know of - if someone copies and pastes the theme folder in, there's no file handling by WP whatsoever. We know it should be 644, so let's make it that instead of 755 which these two files happened to be (example.php was already 644). @shivapoudel Standard command line: |
…ion into feature/file-permissions # By jrfnl (13) and Gary Jones (1) # Via Gary Jones (7) and others * 'develop' of github.com:thomasgriffin/TGM-Plugin-Activation: Minor spelling & documentation fixes Make sure the `$actions` variable is always available Fix some minor issues detected in code inspection Update Travis config Minor fixes Allow for single file plugins & improve checks on non-standard packages Add an example for GitHub based repositories to the example plugin config. Adjust plugin directory name for "wrongly" packaged zips. Fix too rigorous escaping preventing js toggle from working Only flush the plugins cache, not *all* WP caches. Add inline documentation Escape some more output Add back some escapes which were added in 2.4.1 but not carried over to develop Fix issues with bulk installing pre-packaged/bundled plugins.
Member
Author
|
Unconflicted. |
Contributor
|
@GaryJones Thanks! IMO this PR is ready to get merge ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.