Abstract duplicate code to retrieve a plugin information link#374
Merged
Abstract duplicate code to retrieve a plugin information link#374
Conversation
class-tgm-plugin-activation.php
Outdated
Member
There was a problem hiding this comment.
Why is this one named with "plugin", yet the get_download_link() method isn't? Both are talking about plugins, so some consistency either way would be nice.
Contributor
Author
There was a problem hiding this comment.
Because the WP api for this calls it plugin information...
Contributor
Author
|
PR updated |
- rename the method - add some documentation
jrfnl
force-pushed
the
feature/abstract-plugin-info-url
branch
from
eb41dab to
3aee995
Compare
GaryJones
added a commit
that referenced
this pull request
Apr 28, 2015
…fo-url Abstract duplicate code to retrieve a plugin information link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.