Add some html wrapper methods for use with array_map() ...#376
Merged
Add some html wrapper methods for use with array_map() ...#376
Conversation
…their use. Also: Fix some html errors in the notice output
Member
There was a problem hiding this comment.
Do we need any checks here to make sure both plural and singular versions of $this->strings[ $type ] have exactly two placeholders?
Contributor
Author
There was a problem hiding this comment.
If we'd go that way, we'd have to do that for quite a few strings I think - would be more appropriate in a method which reads in all the strings. Then again - what to do if a custom string or a translation doesn't have the right nr of placeholders ? Fall back to our default in English ? That could make for some strange mixed language pages, including mixed terminology (plugin/theme requires .. etc).
Let leave it to the configurators and translators for now until someone reports an issue with it.
GaryJones
added a commit
that referenced
this pull request
Apr 28, 2015
Add some html wrapper methods for use with array_map() ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and implement their use.
Also:
Fix some html errors in the notice output