Skip to content

Housekeeping WPCS / Docs #384

Merged
GaryJones merged 2 commits intodevelopfrom
feature/docs
May 4, 2015
Merged

Housekeeping WPCS / Docs #384
GaryJones merged 2 commits intodevelopfrom
feature/docs

Conversation

@jrfnl
Copy link
Copy Markdown
Contributor

@jrfnl jrfnl commented May 4, 2015

Solve nearly all issues which would start to pop up once WordPress-Doc sniffs are included.

@jrfnl jrfnl added this to the 2.5.0 milestone May 4, 2015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be missing a name...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for me to add ;-)

- Remove references to 'hover' links as they are now always visible
- Bring back @return null
- Whitelist two $_POST uses for CSRF sniff
- Some if/else braces fixes
@jrfnl
Copy link
Copy Markdown
Contributor Author

jrfnl commented May 4, 2015

Adjusted & pushed + extra comments to WPCS Doc sniff thread added

GaryJones added a commit that referenced this pull request May 4, 2015
@GaryJones GaryJones merged commit 6ca3a2c into develop May 4, 2015
@GaryJones GaryJones deleted the feature/docs branch May 4, 2015 23:10
@GaryJones
Copy link
Copy Markdown
Member

I had confirmation from @DrewAPicture regarding @return null too, so we're all good there.

@jrfnl
Copy link
Copy Markdown
Contributor Author

jrfnl commented May 4, 2015

Good - do see my comments on the WPCS-Docs commit then as that does mean that another rule needs to be excluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants