Merged
Conversation
Contributor
There was a problem hiding this comment.
The -v and -n flag are currently not included in the ruleset file.
Member
Author
There was a problem hiding this comment.
They don't need to be. -n is for ignoring warnings (which we shouldn't do), and -v is for verbose, and I've not found that to be any more useful than what the full report already provides.
Travis and local runs use the same config as provided by phpcs.xml.
GaryJones
force-pushed
the
feature/phpcs-docs
branch
from
a9408e1 to
a67b8ca
Compare
* Remove use of var_dump() completely. * Switch to phpcs.xml and remove flags from Travis. (+1 squashed commit) Squashed commits: [36e0340] Improve PHPCS checks. Exclude a couple of commenting rules that WPCS will almost certainly not exclude, but that we currently fail on.
GaryJones
force-pushed
the
feature/phpcs-docs
branch
from
a67b8ca to
75a2bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally branched to support the docs branch of WPCS, most of the issues have already been addressed in PRs already merged into dev.
What remains then is a readme update, and a few small tweaks.