Skip to content

Fixed: Wrong class for notification box#478

Closed
Ninos wants to merge 2 commits intoTGMPA:developfrom
Ninos:fixed-styling
Closed

Fixed: Wrong class for notification box#478
Ninos wants to merge 2 commits intoTGMPA:developfrom
Ninos:fixed-styling

Conversation

@Ninos
Copy link
Copy Markdown
Contributor

@Ninos Ninos commented Sep 4, 2015

No description provided.

@jrfnl
Copy link
Copy Markdown
Contributor

jrfnl commented Sep 4, 2015

The update-nag class was introduced in 3.9, you are now disabling it effectively. Any particular reason ?

@Ninos
Copy link
Copy Markdown
Contributor Author

Ninos commented Sep 4, 2015

huh really? Because of following styling:
tgmpa - notice box

WP v4.3

@jrfnl
Copy link
Copy Markdown
Contributor

jrfnl commented Sep 5, 2015

I don't get it - what do you mean ? Looks ok to me, though maybe we should disable the dismiss button or remove our own dismiss text if on 4.3 or up (now double with different logic behind it).

@Ninos
Copy link
Copy Markdown
Contributor Author

Ninos commented Sep 5, 2015

No, I just mean that the box does not use the full line / width anymore.

@Ninos
Copy link
Copy Markdown
Contributor Author

Ninos commented Sep 23, 2015

Ok I don't konw in which version they changed the class name back to "updated", but in v4.3 wordpress is definitely using updated instead of update-nag.

I've commited some changes.

@primozcigler primozcigler mentioned this pull request Nov 29, 2015
Closed
jrfnl added a commit that referenced this pull request Jan 5, 2016
@jrfnl
Fix admin notice class.
5b057f5 
Semi-consistent display of the admin notice.

Fixes #478, #495. Props @Ninos

Work around all the changes to the various admin notice classes between WP 4.4 and 3.7 (lowest WP version currently supported by TGMPA).
@jrfnl jrfnl mentioned this pull request Jan 5, 2016
Merged
@jrfnl
Copy link
Copy Markdown
Contributor

jrfnl commented Jan 5, 2016

Hi @Ninos I finally had time to properly test this and ended up with a slightly different implementation #509 for consistency. Thank you for bringing this to our attention and I look forward to your next pull request.

@jrfnl jrfnl closed this Jan 5, 2016
@Ninos Ninos deleted the fixed-styling branch January 5, 2016 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: Admin Notices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ninos @jrfnl
⚡