Skip to content

Updated for best practices & coding standards.#2

Merged
GaryJones merged 1 commit intomasterfrom
feature/bring-up-to-scratch
Apr 2, 2016
Merged

Updated for best practices & coding standards.#2
GaryJones merged 1 commit intomasterfrom
feature/bring-up-to-scratch

Conversation

@jrfnl
Copy link
Copy Markdown
Contributor

@jrfnl jrfnl commented Apr 2, 2016

  • Added file header
  • Localized and escaped the text string
  • Applied best practices and coding standards
  • Added readme.txt
  • Added license file

Tested & found working in WP 4.5

These changes are the same as the ones contained in TGMPA/TGM-Plugin-Activation#557
Once this PR is merged, PR TGMPA/TGM-Plugin-Activation#557 can be merged too.

* Added file header
* Localized and escaped the text string
* Applied best practices and coding standards
* Added readme.txt
* Added license file

Tested & found working in WP 4.5
* @copyright 2011-2016 Thomas Griffin
* @license http://creativecommons.org/licenses/GPL/3.0/ GNU General Public License, version 3 or higher
*
* Plugin Name: TGM Example Plugin
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @wordpress-plugin tag is needed before this line. Non-tagged comments are not valid after PHPDoc tags.

@GaryJones GaryJones merged commit b762cad into master Apr 2, 2016
@GaryJones
Copy link
Copy Markdown
Member

Merged, but I'd like to see a README.md added to this repo to explain what the repo is.

@jrfnl jrfnl deleted the feature/bring-up-to-scratch branch April 2, 2016 15:47
@jrfnl
Copy link
Copy Markdown
Contributor Author

jrfnl commented Apr 2, 2016

In the absence of a readme.md, the readme.txt file which I added will display by default on the main page. Will that do ?

@GaryJones
Copy link
Copy Markdown
Member

I just can't stand the look of .txt for readme's on GitHub :-)

@jrfnl
Copy link
Copy Markdown
Contributor Author

jrfnl commented Apr 2, 2016

grin I can get that, still how much effort do we want to put into an example plugin which is only intended to demonstrate the capabilities of TGMPA ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants