Conversation
TobiGr
added
bug
TobiGr
force-pushed
the
ccc
branch
3 times, most recently
from
8d83786 to
e9c38bd
Compare
AudricV
changed the title
AudricV
previously requested changes
Sep 23, 2023
| public String getName() throws ParsingException { | ||
| return roomInfo.getObject("talks").getObject("current").getString("title"); | ||
| if (isBreak()) { | ||
| return roomInfo.getString("display") + " - Pause"; |
Member
There was a problem hiding this comment.
How MediaCCC's website displays paused rooms? I don't think hardcoding - Pause at the end of a room name is a good idea for localization purposes.
Contributor
Author
There was a problem hiding this comment.
what else do you suggest? just remove it? Or use "Break"?
Member
There was a problem hiding this comment.
I don't know so let's use this for now :P
Add and improve tests for MediaCCCLiveStreamKioskExtractor: - test stream items if a live stream is running - use mock tests to check live talk extraction and testing conferences
|
Contributor
Author
|
Failing tests are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix wrong ListLinkHandlerFactories for kiosks. Regression introduced in Add support for channel tabs and channel tags #1082. I checked for similar regressions, but did not find any.was already done in a separate PR.MediaCCCLiveStreamKioskExtractor:This re-introduces the
@MockOnlyannotation for classes andMockOnlyConditionfor tests removed in #1332To Do
MediaCCCLiveStreamListExtractorTest.[PreparationTest|LiveConferenceTest]always use mocks.