[YouTube] Fix extraction of playlist items and some properties in lockup view models#1503
Merged
TobiGr merged 8 commits intoJun 9, 2026
Conversation
AudricV
added
bug
This was referenced May 31, 2026
AudricV
force-pushed
the
yt_fix-lockups-stream-items-parsing-in-some-cases
branch
from
a3c0acf to
2e49ffc
Compare
AudricV
changed the title
Member
|
When going to https://www.youtube.com/@wildlifeaid live tab I am getting these exceptions. I presume from their 3 livestreams that are live right now. Exception
Exceptions (3)
Crash log 1
Crash log 2
Crash log 3
|
Member
Author
|
It should be fixed with e9cd77e. |
- Fix parsing of upload date of livestreams premiered; - Handle properly date and view count parsing for members first or members only content; - Use again direct access with indexes to parse view count and date, this reduces usage of language dependant methods. Order of metadata parts has been observed to always be [view count, upload date]; - Handle missing metadata rows directly to throw better exceptions, making easier to debug the source of lack of stream details; - Refactor how channel lockups video items are detected, by replacing method getInfoMetadataRowIndex with isChannelLockupItem; - Decrease Java's Stream API usage to reduce complexity.
lockupViewModelChannelTabSectionHeader's case has never been observed in the YouTube extracted endpoints we use.
Also check content availability for all tests of YoutubeStreamInfoItemTest. Co-authored-by: FineFindus <FineFindus@proton.me>
Also do some refactor/optimizations in YoutubePlaylistExtractor on the fly.
TobiGr
force-pushed
the
yt_fix-lockups-stream-items-parsing-in-some-cases
branch
from
482b7c6 to
a6f1feb
Compare
|
TobiGr
approved these changes
Jun 9, 2026
TobiGr
left a comment
TobiGr
left a comment
Contributor
There was a problem hiding this comment.
Thanks. I reviewed briefly and did not find anything interesting. Just applied minor stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, on lockup view models of streams:
getContentAvailabilityin lockup stream items;lockupViewModelChannelTabSectionHeader) and adds one for members only in a channel (with the test data from feat: support ContentAvailability for video lockup metadata #1497 with some unneeded data removed);I tested with the current extractor tests, using mocks and online version and also the channels given in TeamNewPipe/NewPipe#13540 (comment), everything seem to work properly.
Supersedes #1496 and #1497.
Fixes TeamNewPipe/NewPipe#13540 (at least the last comments), fixes TeamNewPipe/NewPipe#13552.