Skip to content

[YouTube] Mark auto-dubbed streams as auto-generated #1507

Open
FineFindus wants to merge 2 commits into
TeamNewPipe:devfrom
FineFindus:feat/audio-track-auto-generated
Open

[YouTube] Mark auto-dubbed streams as auto-generated #1507
FineFindus wants to merge 2 commits into
TeamNewPipe:devfrom
FineFindus:feat/audio-track-auto-generated

Conversation

@FineFindus

@FineFindus FineFindus commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Marks auto-dubbed audio tracks as auto-generated. This allows applications to handle them differently to non-auto-generated audio tracks, e.g. display this information to the user. I explicitly left it as a more general method, rather than restricting it audio tracks only, as video tracks may also be auto-generated in the future.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@FineFindus FineFindus force-pushed the feat/audio-track-auto-generated branch from 85eacb3 to 8a7ac03 Compare June 7, 2026 06:50
@TobiGr

TobiGr commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Thank you!

YoutubeStreamExtractorDefaultTest$AutoGeneratedAudio > testAutogeneratedTracks() FAILED
    java.lang.RuntimeException: Failed to init extractor
        at org.schabi.newpipe.extractor.services.DefaultSimpleUntypedExtractorTest.extractor(DefaultSimpleUntypedExtractorTest.java:40)
        at org.schabi.newpipe.extractor.services.youtube.stream.YoutubeStreamExtractorDefaultTest$AutoGeneratedAudio.testAutogeneratedTracks(YoutubeStreamExtractorDefaultTest.java:638)

This needs to be fixed, most probably be re-recording the corresponding mock

Marks auto-dubbed audio tracks as auto-generated. This allows applications to
handle them differently to non-auto-generated audio tracks, e.g. display this
information to the user.
@FineFindus FineFindus force-pushed the feat/audio-track-auto-generated branch from 8a7ac03 to ea8cd11 Compare June 7, 2026 11:12
@sonarqubecloud

sonarqubecloud Bot commented Jun 7, 2026

Copy link
Copy Markdown

@TobiGr TobiGr added the YouTube Service, https://www.youtube.com/ label Jun 7, 2026
@AudricV

AudricV commented Jun 7, 2026

Copy link
Copy Markdown
Member

My upcoming Stream API refactor will support this for all stream types on all services, so we should close this PR in my opinion.

@TobiGr

TobiGr commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

I'd be in favor of merging this as we do not have an ETA for the stream API refacator, have we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

YouTube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants