[YouTube] Workaround SABR enforcement by using another player client#1508
Merged
Conversation
Videos made for kids cannot be watched with the VISIONOS client, so only the 360p muxed stream currently extracted can be got.
AudricV
added
bug
|
This was referenced Jun 8, 2026
|
Can we get a testing apk to try it out? (since doing so also helped to find that videos for kids dont work) |
TobiGr
approved these changes
Jun 9, 2026
TobiGr
left a comment
TobiGr
left a comment
Contributor
There was a problem hiding this comment.
Thanks. We'll have to fix the broken stuff later.
Member
|
What makes this multiservice and not just youtube? @AudricV |
Member
Author
|
@absurdlylongusername The |
Merged
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works around the SABR enforcement on the client we use by fetching another one not yet affected. Note that like the
ANDROID_VRone it doesn't support made for kids videos (soYoutubeStreamExtractorDefaultTest.RatingsDisabledtest is failing, as no audio and video only streams can be get), but it supports multiple audio tracks.YoutubeStreamExtractorUnlistedTestis now failing too, this needs to be investigated later.This PR also allows DASH and HLS manifests to be only available, as they can be the only source available for livestreams.
Supersedes #1498 and #1499, fixes TeamNewPipe/NewPipe#13320 and fixes TeamNewPipe/NewPipe#13556.