Remove packaging used for obsolete version check#289
Merged
justinmayer merged 1 commit intoTeemu:mainfrom Nov 14, 2024
Merged
Conversation
auvipy
requested changes
Nov 13, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
can you please check the failing build?
deronnax
force-pushed
the
remove-packaging-dep
branch
from
6a67610 to
c123be0
Compare
Author
|
sure. Here you go. Tested locally |
justinmayer
changed the title
packaging used for obsolete version check
justinmayer
approved these changes
Nov 14, 2024
Collaborator
justinmayer
left a comment
justinmayer
left a comment
There was a problem hiding this comment.
Thank you for these improvements, Mathieu 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what it used for could be done without, but more importantly, pytest-1.14 was almost released 9 years ago in January 2016, there is no chance a recent install of pytest-sugar has it.
I tried and installed pytest-xdist 1.14 on a pytest 7 install and pytest would not even launch.
So it's safe to assume pytest-xdist will always be (way) more recent than 1.14.
It saves few kb at install size and few secs at install time.