Multi-GPU Fixed Static Noise + Batch Mode, Embedding Prompt in Metadata, Etc#58
Open
pftq wants to merge 39 commits intoTencent-Hunyuan:mainfrom
Open
Multi-GPU Fixed Static Noise + Batch Mode, Embedding Prompt in Metadata, Etc#58pftq wants to merge 39 commits intoTencent-Hunyuan:mainfrom
pftq wants to merge 39 commits intoTencent-Hunyuan:mainfrom
Conversation
…o video metadata comments, use FFMPEG for higher quality when available.
…ivisibility issues
This was referenced Mar 31, 2025
Contributor
Author
|
This also indirectly fixed #60 (comment) |
…on diviser after GPU count.
Contributor
Author
|
Fixed one more bug in the resizing code. If you try 720x720 (540p) on 8 GPUs, it'll run into divisibility issues again. I managed to fix it by having the crop_size_list regenerated based on the diviser instead of 32, so it looks like the list/filter doesn't quite work and it's safer to just generate a new crop list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The video has half the screen covered in static noise when using multi-GPU with 2 GPUs, 3/4 of the screen when using 4 GPUs, etc. This happens when seed is not specified because each GPU generates its own random seed and doesn't sync. This fixes that bug identified here:
#35
Additionally, I implemented the --batch-size to allow for batch creation of videos without reloading the model each time. There are also other quality-of-life features: