fix(notification): replace post_api with requests for large payload requests#2093
Merged
prathameshkurunkar7 merged 1 commit intodevelopfrom Mar 28, 2026
Conversation
prathameshkurunkar7
deleted the
fix-large-payloads-in-notifications-not-being-sent-issue
branch
prathameshkurunkar7
added a commit
that referenced
this pull request
Mar 28, 2026
fix(notification): replace post_api with requests for large payload requests (#2093)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the long pending issue of JSONDecode Error on sites in Error Logs for Notifications which had large payloads.
Hopefully we have way more notification reliability.
The
post_apimethod inFrappeClientuses params while making POST requests which is firstly not ideal as it sends everything in URL. It should use data/json from requests lib instead. But changing core functionality in Framework might have led to potentially other issues.The simplest fix was to either use the
post_requestmethod or simply use the requests lib directly. Went ahead with requests lib to keep the semantics not weird.