fix(notifications)!: improve notification handling in service worker#2126
Merged
prathameshkurunkar7 merged 1 commit intodevelopfrom Apr 17, 2026
Merged
Conversation
Member
|
Maybe we should remove the option for Frappe Cloud as a notification service altogether. Always have them select Raven since we maintain this. |
Member
Author
Yeah, created a separate issue for that, will do that separately. Need to first merge and check whether this completely resolves the PWA duplicate issue on prod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Per Firebase docs, a push with both notification and data payload makes FCM's default handler auto-display a notification and trigger onBackgroundMessage — our SW then renders a second one via showNotification(), so users see two notifications for every push on PWAs.
Paired with the backend change (Raven Cloud now sends Web clients a data-only payload), this ensures FCM no longer auto-displays and our SW remains the sole renderer — exactly one notification per push, with all existing click routing / Chrome-vs-others behavior preserved.
On Rollout
We need some way to communicate this to everyone using Raven to update to new version once this is merged. @nikkothari22