Add volume control && volume bar && duration display#82
Add volume control && volume bar && duration display#82AaronTYZ wants to merge 5 commits intoTheWidlarzGroup:masterfrom
Conversation
|
I'm still interested in this PR. I can totally understand that after 11 months you might not have interest in this PR, but I hope at least the owner @cornedor can look into this PR and make it happen. |
| } | ||
|
|
||
| onVolCtrlGrant(e) { | ||
| console.log("Test vol ctrl grant start, pos=", e.nativeEvent.pageY); |
There was a problem hiding this comment.
I'd recommend prior to this being pulled in to remove all console.logs.
|
|
||
| onVolControl(e) { | ||
| let volume = this.state.volume; | ||
| const senseFactor = 5/4; |
|
Ah :) Didn't realize this was 11 months old. Do like the capability that it could add and thank you for the work! @cornedor did you consider this addition? |
|
In your formatTime method, i think there should be sec = '0' + sec.toString(); instead of minute = '0' + sec.toString();, |
|
Hey, thanks for your amazing work! We completely rebuilt this library. If you could resolve the conflicts and add it to the latest codebase, that would be great! |
6 participants
Volume control new supported.
Volume bar display when tap.
Video duration display along with control bar.
Good Interative.
Before merged, u can ref to here