Skip to content

Add function: aiofiles.os.access()#146

Merged
Tinche merged 5 commits into
Tinche:masterfrom
rexzhang:master
Sep 7, 2022
Merged

Add function: aiofiles.os.access()#146
Tinche merged 5 commits into
Tinche:masterfrom
rexzhang:master

Conversation

@rexzhang

@rexzhang rexzhang commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

issue # 145

@rexzhang

rexzhang commented Sep 7, 2022

Copy link
Copy Markdown
Contributor Author

Please wait some time, I will add more unit test

@rexzhang

rexzhang commented Sep 7, 2022

Copy link
Copy Markdown
Contributor Author

finished

@Tinche

Tinche commented Sep 7, 2022

Copy link
Copy Markdown
Owner

Add a changelog fragment too please (create a new section for 22.2.0 if it's not there).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 89.86% // Head: 89.90% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (849cb02) compared to base (8c7b922).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   89.86%   89.90%   +0.03%     
==========================================
  Files          10       10              
  Lines         306      307       +1     
==========================================
+ Hits          275      276       +1     
  Misses         31       31              
Impacted Files Coverage Δ
src/aiofiles/os.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rexzhang

rexzhang commented Sep 7, 2022

Copy link
Copy Markdown
Contributor Author

Add a changelog fragment too please (create a new section for 22.2.0 if it's not there).

done

@rexzhang rexzhang changed the title Add function: aiofiles.os.access() #145 Add function: aiofiles.os.access() Sep 7, 2022
@Tinche

Tinche commented Sep 7, 2022

Copy link
Copy Markdown
Owner

Thanks! The failing test is a pip bug, so I'm going to merge this in.

@Tinche Tinche merged commit 8586d24 into Tinche:master Sep 7, 2022
@sfgeorge sfgeorge mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants