Skip to content

Added Manifest file #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tinche merged 1 commit into from
Oct 21, 2017
Merged

Added Manifest file #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
recursive-include aiofiles *.py

@asvetlov asvetlov Nov 12, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line should be removed: setuptools/distutils has a rule to include all .py files from mentioned packages.

@merwok merwok Nov 29, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true.


include README.rst
include MANIFEST.in

@asvetlov asvetlov Nov 12, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a comment after merging but MANIFEST.in is not needed in the file.
Maybe it doesn't make a harm but no other project has the line IMHO.
I'm pretty sure aio-libs: aiohttp, yarl, multidict and others works pretty well.

@merwok merwok Nov 29, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MANIFEST.in, MANIFEST and setup.py don’t need to be in MANIFEST.in, indeed.

include LICENSE
include setup.py
⚡