NPE in expansion with github's API

[kubukoz]

Using this: https://github.com/github/rest-api-description/blob/31d31192bacb4e883b7c66c930f4a95078bcaa5a/descriptions/api.github.com/api.github.com.yaml

//> using dep dev.continuously.jing::jing-openapi:0.0.2
//> using option -experimental

val api = jing.openapi("./github.yaml")

produces an NPE at compile time:

Exception occurred while executing macro expansion.
java.lang.NullPointerException: Cannot invoke "io.swagger.v3.oas.models.OpenAPI.getComponents()" because "spec" is null
	at jing.openapi.SwaggerToScalaAst$.apply(SwaggerToScalaAst.scala:63)
	at jing.openapi.package$.go(package.scala:13)
	at jing.openapi.package$.inline$go(package.scala:10)

[TomasMikula]

Hey, thanks for trying it out and reporting!
I got the same yesterday, after you shared the GitHub API with me :)
The null comes from an enum case, which the Swagger parser represents as a Java null (hence NPE), and I frankly did not account for nulls in enums.

[TomasMikula]

The good news is, the NPEs were easy to fix. The bad news is, the macro then runs for 6-7 minutes to just construct the Expr it returns to the compiler, and the compiler effectively does not terminate (I gave it ~30 minutes before killing it) compiling it 🤦‍♂️
Will need to dig in and potentially open some compiler performance tickets.

[kubukoz]

Could the macro also be made more lazy? Like, return the top-level expression immediately but make the nested expressions macros as well? (i.e. only create the sub-exprs if someone actually uses them)

[TomasMikula]

That's an interesting idea. However, I don't readily see how to take advantage of it here.