tree.py enhancements and tests#636
Merged
bartlettroscoe merged 4 commits intoTriBITSPub:masterfrom Sep 20, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the tree.py utility with improved command-line options and comprehensive test coverage. The changes modernize the option interface and fix several functional issues.
- Enhanced exclude functionality to support multiple entries and comma-separated lists
- Fixed option naming consistency and added long-form alternatives
- Added comprehensive unit tests with golden output validation
Reviewed Changes
Copilot reviewed 3 out of 11 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tribits/python_utils/tree.py | Enhanced exclude logic, fixed option naming, and improved command-line interface |
| test/python_utils/tree_unittests.py | Added comprehensive test suite with golden output tests for all functionality |
| test/python_utils/CMakeLists.txt | Added test configuration for the new unit tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+129
to
+130
| if exc_entry is None: | ||
| continue |
There was a problem hiding this comment.
This None check is unnecessary since options.exclude is only set when the option is provided, and action='append' with default=None means individual entries cannot be None.
Suggested change
| if exc_entry is None: | |
| continue |
NOTE: You can't use the real directory name ".git" because git will not allow you to commit files under that directory.
bartlettroscoe
force-pushed
the
tree-exclude-list
branch
from
1305586 to
fbebffb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.