Skip to content

Commit e014360

Browse files
committed
Configure github CI to use the node version set in .nvmrc, removes additional hardcoded nodejs version config, and makes it easier to upgrade nodejs in the future and to keep tests on dev machines and github CI running with same dependencies
1 parent 5d079e7 commit e014360

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/actions/setup-env/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ runs:
1818
steps:
1919
- uses: actions/setup-node@master
2020
with:
21-
node-version: 20.20.0
21+
node-version: "../../.nvmrc"
2222

2323
- name: Set up Python 3.12
2424
uses: actions/setup-python@v5

.github/workflows/e2e-android.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515

1616
- uses: actions/setup-node@master
1717
with:
18-
node-version: 20.20.0
18+
node-version: "../../.nvmrc"
1919

2020
- name: Install dependencies
2121
run: |

.github/workflows/e2e-ios.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515

1616
- uses: actions/setup-node@master
1717
with:
18-
node-version: 20.20.0
18+
node-version: "../../.nvmrc"
1919

2020
- name: Install dependencies
2121
run: |

packages/desktop/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Here are the steps:
55

66
1. Install `patch` via your Linux package manager (you can skip this step on Mac because it is already installed)
77

8-
2. Use `Node 20.20.0` and `npm 10.8.2`. We recommend [nvm](https://github.com/nvm-sh/nvm) or [volta](https://volta.sh/) for easily switching Node versions, and if this README gets out of date you can see the actual version used by CI [here](https://github.com/TryQuiet/quiet/blob/master/.github/actions/setup-env/action.yml). If you are using nvm, you can run `nvm use` in the project's root to switch to the correct version.
8+
2. Use `Node 20.20.0` and `npm 10.8.2`. We recommend [nvm](https://github.com/nvm-sh/nvm) or [volta](https://volta.sh/) for easily switching Node versions, and if this README gets out of date you can see the actual version used by CI [here](https://github.com/TryQuiet/quiet/blob/master/.nvmrc). If you are using nvm, you can run `nvm use` in the project's root to switch to the correct version.
99

1010
3. Install python3 and setuptools through your preferred method. (used by node-gyp)
1111

0 commit comments

Comments
 (0)