Merged
Conversation
…cause it was easier to start fresh--but who took a first pass on this and got something working! <3)
Collaborator
Author
|
@islathehut this is ready for review for reals now. |
pdurbin
reviewed
Apr 11, 2025
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
adrastaea
approved these changes
Apr 14, 2025
Collaborator
adrastaea
left a comment
adrastaea
left a comment
There was a problem hiding this comment.
Approving despite my stylistic preference note. Will leave it up to you whether you agree and want to change that behavior before merging or make an issue to address later.
…nelInput/ChannelInput.tsx Co-authored-by: Taea <88346289+adrastaea@users.noreply.github.com>
…ut leaves a note for posterity so they don't get added back when someone asks for them
Collaborator
Author
|
@adrastaea noting this here, too: f91cc9d it's another funny issue with parsing emojis, this time with our linter! |
adrastaea
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds emojicodes (:heart:), emoticons (<3), tab completion, a dropdown, and actually bright red hearts, for better vibes. (Our hearts had been very 1980s ASCII goth.)
Pull Request Checklist