Skip to content

iOS Push Notification Support#3125

Merged
mcginty merged 10 commits intodevelopfrom
mcginty/ios-notifications
Mar 19, 2026
Merged

iOS Push Notification Support#3125
mcginty merged 10 commits intodevelopfrom
mcginty/ios-notifications

Conversation

@mcginty
Copy link
Copy Markdown
Collaborator

@mcginty mcginty commented Mar 10, 2026

  • Upgrades the iOS project to build in Xcode 26.3 and work on newer iOS emulators.
  • Adds Firebase libraries as Pods
  • Adds a Network Service Extension with the needed glue to process APN push notifications via Firebase

@mcginty mcginty marked this pull request as ready for review March 16, 2026 06:55
@adrastaea adrastaea self-requested a review March 16, 2026 16:18
adrastaea
adrastaea requested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@adrastaea adrastaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble building from this commit. I did some troubleshooting yesterday, and the main things blocking seem to be some xcode 26 specific features that got in that meant I needed to bump our xcodeproj gem to 1.27.0 to get the pod install to work, personal signing credentials getting committed, and the GoogleService-Info.plist resource being blocking to the build if not present and also causing a crash if mock data was used. I have a patch I'll send you over with the changes I had to make to get it running.

Comment thread packages/mobile/ios/Quiet.xcodeproj/project.pbxproj Outdated
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.quietmobile;
PRODUCT_BUNDLE_IDENTIFIER = org.jakebot.quietmobile;
Copy link
Copy Markdown
Collaborator

@adrastaea adrastaea Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing these changes to bundle identifier and team id snuck in because you didn't have team permissions yet. Need to revert before merging

Suggested change
PRODUCT_BUNDLE_IDENTIFIER = org.jakebot.quietmobile;
PRODUCT_BUNDLE_IDENTIFIER = com.quietmobile;

Comment thread packages/mobile/ios/Quiet.xcodeproj/project.pbxproj Outdated
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "set -e\n\n# Fix for machines using nvm\nif [[ -s \"$HOME/.nvm/nvm.sh\" ]]; then\n. \"$HOME/.nvm/nvm.sh\"\nelif [[ -x \"$(command -v brew)\" && -s \"$(brew --prefix nvm)/nvm.sh\" ]]; then\n. \"$(brew --prefix nvm)/nvm.sh\"\nfi\n\nexport NODE_BINARY=node\n../node_modules/react-native/scripts/react-native-xcode.sh\n";
shellScript = "set -e\n\n# Fix for machines using nvm\nif [[ -s \"$HOME/.nvm/nvm.sh\" ]]; then\n. \"$HOME/.nvm/nvm.sh\"\nelif [[ -x \"$(command -v brew)\" && -s \"$(brew --prefix nvm)/nvm.sh\" ]]; then\n. \"$(brew --prefix nvm)/nvm.sh\"\nfi\n\nexport NODE_BINARY=/Users/jakebot/.local/share/mise/installs/node/22.22.0/bin/node\n../node_modules/react-native/scripts/react-native-xcode.sh\n";
Copy link
Copy Markdown
Collaborator

@adrastaea adrastaea Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded node binary to your machine

Comment thread packages/mobile/ios/Quiet.xcodeproj/project.pbxproj
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
EB4DC8172F60A81000EFD23F /* GoogleService-Info.plist in Resources */,
Copy link
Copy Markdown
Collaborator

@adrastaea adrastaea Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a build failure in xcode. I think we could either create a mock version of this with mocked data and a prebuild step to copy that mock into a file by this name, or make a debug version of this that points to a debug firebase project that we don't care about making public.

Copy link
Copy Markdown
Collaborator Author

@mcginty mcginty Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I think a mock is probably the move - I have the file locally and the CI will have it after extracting the secrets, but that leaves devs in a weird place of course :). I can try a mock out!

adrastaea
adrastaea requested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@adrastaea adrastaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments to resolve. I also had to make some changes to get it to build on my machine. I'll send you the patch with those. Just needed to bump the xcodeproj gem version to 1.27.0, revert some of your signing changes you accidentally committed, and make the Firebase configuration more tolerant to mocked data.

@mcginty
Copy link
Copy Markdown
Collaborator Author

mcginty commented Mar 18, 2026

@adrastaea I added a few commits on top of yours that made your build work. I had to actually jump to a fork of Xcodeproj (which hasn't been updated in >2 years) that adds newer Xcode identifier constants.

I also went ahead and moved the project over to the *.xcconfig type setup which makes it easier to specify gitignored overrides for the Team ID and Bundle ID.

Similarly, updated the build script to look for the xcode env files for node overrides to avoid that issue where I had accidentally modified the node search path for everyone else too.

@mcginty mcginty merged commit 7993a25 into develop Mar 19, 2026
37 of 38 checks passed
mcginty added a commit that referenced this pull request Mar 23, 2026
@mcginty @adrastaea
iOS Push Notification Support (#3125)
2e2f5a5 
* Add Firebase support and Network Service Extension for push notifications

* fix extension plist build issues

* add encrypted Firebase plist

* add decryption code for GoogleService-Info.plist

* integrate with Taea's communication module

* move personal changes from .xcode.env to .xcode.env.local

* compatibility fixes

* allow easier overriding of development team and bundle id

* fix more xcodeproj woes, using a fork that works for now

* fix node version build issues for .xcode.env.local

---------

Co-authored-by: taea <taelxvie@gmail.com>
@adrastaea adrastaea linked an issue Mar 24, 2026 that may be closed by this pull request
Create Notification Service Extension Target #3089
Closed
8 tasks
islathehut added a commit that referenced this pull request Apr 15, 2026
@islathehut @mcginty
@adrastaea @bitmold
release: 7.0.1 (#3182)
0f94757 
* update tor

* Publish

 - @quiet/desktop@7.0.1-alpha.0
 - @quiet/mobile@7.0.1-alpha.0

* Update packages CHANGELOG.md

* Publish

 - @quiet/desktop@7.0.1-alpha.1
 - @quiet/mobile@7.0.1-alpha.1

* Update packages CHANGELOG.md

* Publish

 - @quiet/desktop@7.0.1-alpha.2
 - @quiet/mobile@7.0.1-alpha.2

* Update packages CHANGELOG.md

* Publish

 - @quiet/desktop@7.0.1-alpha.3
 - @quiet/mobile@7.0.1-alpha.3

* Update packages CHANGELOG.md

* fix hidden title bar on linux

* fix: Wait for tor kill to finish before moving on (#3134)

* Wait for tor kill to finish before moving on

* Update CHANGELOG.md

* Closes #3123 Removes Superflous @peculiar/webcrypto dependency (#3129)

* Closes #3123 Removes Superflous @peculiar/webcrypto dependency. Removes hacky JavaScript that was needed to override global.crypto

- this was probably needed for along time because iOS was using nodejs12 until some recent work, hence
having no global.crypto flag.
- iOS and Android need the --experimental-global-webcrypto flag until nodejs mobile is rebuilt

* fix soon to be broken github actions that need the node24 runner (#3130)

* iOS Push Notification Support (#3125)

* Add Firebase support and Network Service Extension for push notifications

* fix extension plist build issues

* add encrypted Firebase plist

* add decryption code for GoogleService-Info.plist

* integrate with Taea's communication module

* move personal changes from .xcode.env to .xcode.env.local

* compatibility fixes

* allow easier overriding of development team and bundle id

* fix more xcodeproj woes, using a fork that works for now

* fix node version build issues for .xcode.env.local

---------

Co-authored-by: taea <taelxvie@gmail.com>

* Feat/3086 client push service (#3114)

* request permissions when ios app opens, detect changes to permission on app open

* register when permission is granted and rely solely on event channels for payloads

* simplify sagas, ensure event channels are set up first

* update changelog

* fix mobile unit tests

* pass token to backend and scaffold registration

* cache token until we are part of a community and connected to qss

* update changelog

* fix typo in changelog

* remove caching of device token in redux because it is not needed

* adjust mocks

* try to get around ci weirdness

* fix mobile tests

* add qps consts to test module

* fix state-manager test

* implement storage

* add todos for future work

* remove http related deprecated code

* fix merge conflict

* add qps consts to test module

* adjust mocks

* try to get around ci weirdness

* fix mobile tests

* fix state-manager test

* remove http related deprecated code

* fix: Backend fails to start on GrapheneOS in 6.5.1 (#3106)

* Standardize build config fields to boolean

* Remove call to `free` because it breaks the backend on graphene

* feat(3058): Self-assign member role on joining with QSS and migrate to LFA-based OrbitDB identity (#3102)

* Add lockbox service and create an invite lockbox on invite creation

* Update changelog

* Self-assign member role on join with QSS

* Fix self-assign

* Use event to trigger storage setup after self-assign

* Pull log entries when fully joined via qss (update later to handle joining with peers)

* Move identitieswithstorage

* Get janky LFA identity working with orbitdb and get syncing on join with qss working

* Also pull entries on connection to qss when already a member

* Remove debugging log

* Add comments

* Add comments and return random signature

* Update qss and auth modules to use feature branches for testing

* Update qss e2e test to include joining without peers

* Add self-assign unit tests and fix some unit tests post-LFA identity

* Fix userProfile integration tests

* Update submodules

* Remove changes left in from testing

* Fix last of integration tests and add initializing check to storage init since we can start initialization via qss or libp2p events

* Forgot a comment

* Update CHANGELOG.md

* Update CHANGELOG.md

* Allow strings

* Missed one unit test update

* PR comment fixes

* Add real signatures back to log entries

* Update lfa-identity.service.ts

* release: 6.6.0 (#3109)

* Publish

 - @quiet/desktop@6.6.0-alpha.0
 - @quiet/mobile@6.6.0-alpha.0

* Update packages CHANGELOG.md

* fix: Backend fails to start on GrapheneOS in 6.5.1 (#3106)

* Standardize build config fields to boolean

* Remove call to `free` because it breaks the backend on graphene

* Publish

 - @quiet/desktop@6.6.0-alpha.1
 - @quiet/mobile@6.6.0-alpha.1

* Update packages CHANGELOG.md

* Publish

 - @quiet/desktop@6.6.0
 - @quiet/mobile@6.6.0

* Update packages CHANGELOG.md

* basic implementation

* implement storage

* add todos for future work

* return state

* update test

* skip test for device linking

* skip test for device linking

* test fix

* match send-push name to qps-send-push

* add an individual push option, rename batch push

* match server message format for batch

* increase batch size to 500

* fixed tests

* update changelog

* fix registration flow

* revert interval use in registration

* fix registration

* formatting

* reinforce endpoint fuzzy match with env flag

---------

Co-authored-by: Isla <5048549+islathehut@users.noreply.github.com>

* rm order expectation from test (#3139)

* fix: Allow more fuzziness in team link timestamp validations and use updated logging (#3137)

* Pass logger into team/connection and update auth to use new logging

* Update auth

* Use main auth branch

* Publish

 - @quiet/desktop@7.0.1-alpha.4
 - @quiet/mobile@7.0.1-alpha.4

* Update packages CHANGELOG.md

* mess around with the deployment options

* Publish

 - @quiet/desktop@7.0.1-alpha.5
 - @quiet/mobile@7.0.1-alpha.5

* Update packages CHANGELOG.md

* try macos 15 and xcode 16

* Publish

 - @quiet/desktop@7.0.1-alpha.6
 - @quiet/mobile@7.0.1-alpha.6

* Update packages CHANGELOG.md

* Revert "try macos 15 and xcode 16"

This reverts commit 5af7de9.

* change xcode project compatibility to 16 rather than 12

* Publish

 - @quiet/desktop@7.0.1-alpha.7
 - @quiet/mobile@7.0.1-alpha.7

* Update packages CHANGELOG.md

* add IOS_FIREBASE_KEY secret to env

* Publish

 - @quiet/desktop@7.0.1-alpha.8
 - @quiet/mobile@7.0.1-alpha.8

* Update packages CHANGELOG.md

* remove unused app groups section from entitlements

* add new mobile provisioning profile for network service extension

* decrypt mobile provisioning profiles to the right spot

* Publish

 - @quiet/desktop@7.0.1-alpha.9
 - @quiet/mobile@7.0.1-alpha.9

* Update packages CHANGELOG.md

* Fix the provisioning profile specifier

* Publish

 - @quiet/desktop@7.0.1-alpha.10
 - @quiet/mobile@7.0.1-alpha.10

* Update packages CHANGELOG.md

* add missing provisioning profile mapping

* Publish

 - @quiet/desktop@7.0.1-alpha.11
 - @quiet/mobile@7.0.1-alpha.11

* Update packages CHANGELOG.md

* fix(3146): Fix slow electron startup (#3147)

* Load splash before main view

* Add extra logging to uncover issue

* Try apple silicon build

* Update desktop-build.yml

* Update desktop-build.yml

* Make logs traces

* Add prod arm64 deploy job and run e2e tests on latest macos

* Update main.ts

* Fix issue in unit tests and use latest intel mac runner

* Update CHANGELOG.md

* Update .github/workflows/desktop-build.yml

Co-authored-by: Jake McGinty <me@jakebot.org>

---------

Co-authored-by: Jake McGinty <me@jakebot.org>

* Update notification for arm mac builds (#3151)

* Publish

 - @quiet/desktop@7.0.1-alpha.12
 - @quiet/mobile@7.0.1-alpha.12

* Update packages CHANGELOG.md

* fix(3180): Add mac entitlement to fix arm64 builds (#3181)

* Add entitlement to fix arm64 binaries

* Update changelog

* Publish

 - @quiet/desktop@7.0.1-alpha.13
 - @quiet/mobile@7.0.1-alpha.13

* Update packages CHANGELOG.md

* fix(3140): Validate qss endpoint when qss is allowed to avoid registration loops (#3141)

* Validate qss endpoint when qss is allowed to avoid registration loops

* Update CHANGELOG.md

* Update desktop tests

* Update CreateCommunity.test.tsx

* fix(3127): Only run the qss log sync interval once the auth connection is properly up and running (#3126)

* Only run the qss log sync interval once the auth connection is properly up and running

* Update CHANGELOG.md

* Go back to using connected event because I'm losing my mind

* Update auth to latest

* Clarify naming convention

* Go back to active but rename event to connected

* fix hidden title bar on linux (#3153)

Co-authored-by: taea <taelxvie@gmail.com>

* Publish

 - @quiet/desktop@7.0.1-alpha.14
 - @quiet/mobile@7.0.1-alpha.14

* Update packages CHANGELOG.md

* Publish

 - @quiet/desktop@7.0.1
 - @quiet/mobile@7.0.1

* Update packages CHANGELOG.md

* Move changelog entries to the correct versions

* Update back compat version to 7.0

* Log error on before-quit

* Bump webdriver

* Bump back compat version to 7.0.1

---------

Co-authored-by: Jake McGinty <me@jakebot.org>
Co-authored-by: taea <taelxvie@gmail.com>
Co-authored-by: bitmold <dsnake@protonmail.com>
Co-authored-by: Taea <88346289+adrastaea@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrastaea adrastaea adrastaea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Notification Service Extension Target

2 participants

@mcginty @adrastaea
⚡