Conversation
b8f6c0b to
be66ea7
Compare
… of base64 to file, canonical version has more bug fixes
be66ea7 to
adc9c7f
Compare
Collaborator
Author
|
@holmesworcester if it's necessary to update the slack action, all that probably needs to happen is to fork https://github.com/actions-ecosystem/action-slack-notifier and update it's runs:
using: node12
main: dist/index.jsThat action has been running with node 12, but will most likely behave the same in node 24 (it's been running fine on GitHub with node 20 already...). But again, I don't think making this change is going to be necessary.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently Holmes shared this screenshot from a GitHub actions run:

In it, it shows that 3 actions have still not been updated to do their CI things in node 24 and that GitHub will soon force actions to run with nodejs24. The actions are:
Saionaro/extract-package-versionthis can be trivialy updated to their new 1.4.0 release which explicitly uses node 24TryQuiet/base64-to-fileThis is Quiet's unmodified fork of https://github.com/timheuer/base64-to-file. Quiet's fork had no new commits, and there have been other fixes by the original maintainer. In the near future, there will be a release supporting node24 that Quiet can update to.. Quiet's fork of this repo should be closed