refactor(object-spread): use spread instead of assign#194
Merged
johnnyreilly merged 2 commits intoTypeStrong:masterfrom Dec 24, 2018
Merged
refactor(object-spread): use spread instead of assign#194johnnyreilly merged 2 commits intoTypeStrong:masterfrom
johnnyreilly merged 2 commits intoTypeStrong:masterfrom
Conversation
Member
|
Nice - either way; we transpile typescript down to es2015 so the |
Contributor
Author
Yep! This only impacts test files, and just making them look nicer. Either way we could push this as alpha, or not at all. (Up to you, I don't really mind 😄) |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just following up from #166 and #169:
Since we've already dropped support for Node 6 in #166, object spread properties can now be safely used. (As briefly discussed here)
In
.eslintrc.json,"experimentalObjectRestSpread": trueand"ecmaVersion": 6should be kept, since Node 8 supports 99% of ES2015 features, and object-spread is just a ES2018 feature, but is fully supported in Node 8 and above. (Also mentioned in #169, here)Note: This PR does not introduce any functionality changes