Add Chinese (Simplified) localization by xmmtx · Pull Request #810 · Tyrrrz/YoutubeDownloader

xmmtx · 2026-04-11T08:21:18Z

add chinese

Updated the GitHub Actions workflow to improve structure and added KOOK notification.

xmmtx · 2026-04-11T08:23:55Z

To be precise, it is Simplified Chinese, intended for use in mainland China.

xmmtx · 2026-04-11T08:26:50Z

maybe you can delete my workflows. because i change subscribe to my kook channel

Copilot

Pull request overview

Adds Simplified Chinese localization support to YoutubeDownloader, and also updates the GitHub Actions workflow used to build, package, release, and send release notifications.

Changes:

Added a Simplified Chinese localization dictionary and language option.
Updated system-language detection to map a Chinese culture to the new localization.
Refactored .github/workflows/main.yml (action versions, version parsing, deploy packaging, and notification target).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
YoutubeDownloader/Localization/LocalizationManager.cs	Adds System-language mapping and explicit selection for Simplified Chinese.
YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs	Introduces Simplified Chinese UI strings.
YoutubeDownloader/Localization/Language.cs	Adds a new language enum value and display metadata.
.github/workflows/main.yml	Updates CI/CD pipeline steps, versions, and replaces release notification integration.

Comments suppressed due to low confidence (3)

YoutubeDownloader/Localization/LocalizationManager.cs:56

CultureInfo.CurrentUICulture.ThreeLetterISOLanguageName for Chinese cultures is typically "zho" (ISO 639-2), not "chs" (which matches ThreeLetterWindowsLanguageName). As written, Language.System will likely never auto-select Chinese and will fall back to English. Consider switching this logic to use TwoLetterISOLanguageName/Name for zh-*, or change the compared value to "zho" (or use ThreeLetterWindowsLanguageName consistently).

                    "spa" => SpanishLocalization,
                    _ => EnglishLocalization,
                },
            Language.ChineseSimplified => ChineseSimplifiedLocalization,
            Language.Ukrainian => UkrainianLocalization,
            Language.German => GermanLocalization,
            Language.French => FrenchLocalization,
            Language.Spanish => SpanishLocalization,
            _ => EnglishLocalization,

.github/workflows/main.yml:179

A bot authorization token is committed directly in the workflow (Authorization: Bot ...). This is a secret and should not be stored in the repo; it can be harvested from git history and used to send messages as the bot. Move the token (and likely target_id) into GitHub Secrets and reference it via ${{ secrets.* }}; rotate/revoke the leaked token immediately.
.github/workflows/main.yml:149
deploy uses actions/download-artifact, which requires actions: read permission for the GITHUB_TOKEN. The job permissions were reduced to only contents: write, so artifact download may fail with insufficient permissions. Add actions: read to deploy job permissions (and consider least-privilege for other jobs as well).

      - name: Create package
        working-directory: YoutubeDownloader/
        run: zip -r ../YoutubeDownloader.${{ matrix.rid }}.zip .

      - name: Upload release asset
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        run: >

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

xmmtx · 2026-04-13T14:28:31Z

YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs

+            [nameof(SettingsTitle)] = "设置",
+            [nameof(ThemeLabel)] = "主题",
+            [nameof(ThemeTooltip)] = "首选的用户界面主题",
+            [nameof(LanguageLabel)] = "语言Language",


because i don't want any body change to wrong language than don't know how to change back

YoutubeDownloader/Localization/Language.cs

xmmtx · 2026-04-13T14:34:50Z

.github/workflows/main.yml

 jobs:
  format:
    runs-on: ubuntu-latest
    timeout-minutes: 10
-
    permissions:
      contents: read
-
    steps:
      - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@v4

      - name: Install .NET
        uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5.2.0



it can remove

xmmtx · 2026-04-13T14:34:32Z

.github/workflows/main.yml

    steps:
      - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@v4

      - name: Install .NET
        uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5.2.0



it can remove

xmmtx · 2026-04-13T14:33:58Z

because i don't want anybody change to wrong language than don't know how to change back. then keep english at language buttom

xmmtx · 2026-04-13T14:36:29Z

and all change of workflows can delete

Tyrrrz · 2026-04-14T09:27:10Z

@xmmtx thank you.

I've made some corrections to fit the established conventions.

However, your translations are relying on a slightly outdated string set (see build errors). Please take a look at the base strings (English) on the latest prime branch (https://github.com/Tyrrrz/YoutubeDownloader/blob/prime/YoutubeDownloader/Localization/LocalizationManager.English.cs) and update your strings accordingly.

Copilot

Pull request overview

Adds a new Chinese (Simplified) localization option and wires it into the localization selection logic so the UI can be displayed in Simplified Chinese.

Changes:

Added ChineseSimplified to the Language enum.
Added a new Simplified Chinese localization dictionary (LocalizationManager.ChineseSimplified.cs).
Updated LocalizationManager language selection to route to the new localization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
YoutubeDownloader/Localization/LocalizationManager.cs	Routes System/explicit language selection to the new Simplified Chinese localization.
YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs	Adds Simplified Chinese strings for UI labels/tooltips/dialog messages.
YoutubeDownloader/Localization/Language.cs	Introduces the `ChineseSimplified` language option for settings selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

YoutubeDownloader/Localization/LocalizationManager.cs

YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs

+
+                或者，你也可以下载集成了 FFmpeg 的 {0} 版本。请寻找未标记为 *.Bare 的发布资源。
+
+                点击“下载”跳转到 FFmpeg 下载页面。


YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs

+            [nameof(CloseButton)] = "关闭",
+            [nameof(DownloadButton)] = "下载",
+            [nameof(CancelButton)] = "取消",
+            [nameof(SettingsButton)] = "设置",


YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs

+            [nameof(FFmpegPathMissingMessage)] = """
+                此应用需要 FFmpeg 才能运行，但配置的路径不存在：
+                {0}
+
+                请在设置中更新 FFmpeg 路径，或将其清空以使用自动检测。
+                """,
+            [nameof(FFmpegMissingSearchedLabel)] = "在以下目录中搜索了 '{0}'：",


YoutubeDownloader/Localization/Language.cs

    German,
    French,
    Spanish,
+    ChineseSimplified,


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Updated localization strings for Chinese Simplified, including changes to FFmpeg messages.

xmmtx and others added 25 commits March 21, 2026 10:28

Add Chinese localization for LocalizationManager

ff4885e

Add Chinese and reorder Language enum values

2f46e6b

Rename Chinese localization file to Simplified Chinese

0148537

Add descriptions to language enum values

e794ba8

Rename Chinese localization file for consistency

231116c

AI Fix Chinese

130d18c

try to allow the format

3682bda

try to fix format? Tyrrrz#2

5ff4465

format Tyrrrz#3 !!!

b3f9cfe

format Tyrrrz#4

86a61b8

优化中文本地化字符串格式

24c9be8

fix space format Tyrrrz#6

b1e0173

format Tyrrrz#7

3ca4d59

format Tyrrrz#8

e4a22bf

format Tyrrrz#9

0e87353

fix chinese

d903ee8

fix chinese Tyrrrz#3

510bc22

auto format Tyrrrz#10

d59d5be

update actions

4009baa

Refactor workflow and add KOOK notification

860fd61

Updated the GitHub Actions workflow to improve structure and added KOOK notification.

Update KOOK notification with hardcoded values

c1621f4

Merge branch 'Tyrrrz:prime' into main

a6a0706

fix chinese

923a8b3

Merge branch 'main' of https://github.com/xmmtx/YouTube-Downloader

d5daa2b

Merge branch 'Tyrrrz:prime' into main

b041ee0

Tyrrrz requested a review from Copilot April 13, 2026 14:21

Copilot started reviewing on behalf of Tyrrrz April 13, 2026 14:22 View session

Merge branch 'prime' into main

8b23b3a

Tyrrrz added the enhancement New feature or request label Apr 13, 2026

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Tyrrrz changed the title ~~add chinese~~ Add Simplified Chinese localization Apr 14, 2026

Tyrrrz changed the title ~~Add Simplified Chinese localization~~ Add Chinese (Simplified) localization Apr 14, 2026

Tyrrrz added 6 commits April 14, 2026 12:08

Delete .github/workflows/main.yml

9073615

Create main.yml

6afbf2b

Update Language.cs

3e48707

Update LocalizationManager.ChineseSimplified.cs

5ab1ea7

Update LocalizationManager.cs

4c97506

Update Language.cs

908722c

Tyrrrz approved these changes Apr 14, 2026

View reviewed changes

Tyrrrz requested a review from Copilot April 14, 2026 09:23

Copilot started reviewing on behalf of Tyrrrz April 14, 2026 09:24 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

xmmtx and others added 2 commits April 14, 2026 21:03

Potential fix for pull request finding

ee052c0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Modify Chinese localization for FFmpeg messages

fd05ce6

Updated localization strings for Chinese Simplified, including changes to FFmpeg messages.

xmmtx requested a review from Tyrrrz April 14, 2026 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Chinese (Simplified) localization#810

Add Chinese (Simplified) localization#810
xmmtx wants to merge 34 commits intoTyrrrz:primefrom
xmmtx:main

xmmtx commented Apr 11, 2026 •

edited

Loading

Uh oh!

xmmtx commented Apr 11, 2026

Uh oh!

xmmtx commented Apr 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

xmmtx Apr 13, 2026

Uh oh!

Uh oh!

xmmtx Apr 13, 2026

Uh oh!

xmmtx Apr 13, 2026

Uh oh!

xmmtx commented Apr 13, 2026

Uh oh!

xmmtx commented Apr 13, 2026

Uh oh!

Tyrrrz commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		或者，你也可以下载集成了 FFmpeg 的 {0} 版本。请寻找未标记为 *.Bare 的发布资源。

		点击“下载”跳转到 FFmpeg 下载页面。

Uh oh!

Conversation

xmmtx commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xmmtx commented Apr 11, 2026

Uh oh!

xmmtx commented Apr 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

xmmtx Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xmmtx Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

xmmtx Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

xmmtx commented Apr 13, 2026

Uh oh!

xmmtx commented Apr 13, 2026

Uh oh!

Tyrrrz commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xmmtx commented Apr 11, 2026 •

edited

Loading